lix-project/lix
20
57
Fork 31
Code Issues 349 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Do not try to fill fd_set with fd>=FD_SETSIZE

Browse source 
This is UB and causes buffer overflow and crash on linux.
This commit is contained in:
Dmitry Kalinkin 2017-07-18 17:51:50 -04:00
parent 72462b4b6e
commit d5e1bffd2a
No known key found for this signature in database
GPG key ID: 5157B3EC8B2CA333
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/libstore/build.cc
View file

@ -3835,6 +3835,9 @@ void Worker::waitForInput()
int fdMax = 0; int fdMax = 0;
for (auto & i : children) { for (auto & i : children) {
for (auto & j : i.fds) { for (auto & j : i.fds) {
if (j >= FD_SETSIZE) {
throw BuildError("reached FD_SETSIZE limit");
}
FD_SET(j, &fds); FD_SET(j, &fds);
if (j >= fdMax) fdMax = j + 1; if (j >= fdMax) fdMax = j + 1;
} }