lix-project/lix
20
57
Fork 31
Code Issues 349 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Add CURLE_WRITE_ERROR as a transient error condition

Browse source 
We've observed it failing downloads in the wild and retrying the same URL
a few moments later seemed to fix it.
This commit is contained in:
Dan Peebles 2017-04-10 09:28:44 -04:00
parent 53edb55588
commit d1fdade755
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/libstore/download.cc
View file

@ -300,6 +300,11 @@ struct CurlDownloader : public Downloader
|| httpStatus == 504 || httpStatus == 522 || httpStatus == 524 || httpStatus == 504 || httpStatus == 522 || httpStatus == 524
|| code == CURLE_COULDNT_RESOLVE_HOST || code == CURLE_COULDNT_RESOLVE_HOST
|| code == CURLE_RECV_ERROR || code == CURLE_RECV_ERROR
// this seems to occur occasionally for retriable reasons, and shows up in an error like this:
// curl: (23) Failed writing body (315 != 16366)
|| code == CURLE_WRITE_ERROR
// this is a generic SSL failure that in some cases (e.g., certificate error) is permanent but also appears in transient cases, so we consider it retryable // this is a generic SSL failure that in some cases (e.g., certificate error) is permanent but also appears in transient cases, so we consider it retryable
|| code == CURLE_SSL_CONNECT_ERROR || code == CURLE_SSL_CONNECT_ERROR
#if LIBCURL_VERSION_NUM >= 0x073200 #if LIBCURL_VERSION_NUM >= 0x073200