lix-project/lix
20
58
Fork 31
Code Issues 359 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Fix the error when accessing a forbidden path in pure eval

Browse source 
If we’re in pure eval mode, then tell that in the error message rather
than (wrongly) speaking about restricted mode.

Fix https://github.com/NixOS/nix/issues/5611
This commit is contained in:
regnat 2021-11-25 14:48:01 +01:00
parent 1f7584d24c
commit c47027f3a1
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/libexpr/eval.cc
View file

@ -519,8 +519,12 @@ Path EvalState::checkSourcePath(const Path & path_)
} }
} }
if (!found) if (!found) {
throw RestrictedPathError("access to absolute path '%1%' is forbidden in restricted mode", abspath); auto modeInformation = evalSettings.pureEval
? "in pure eval mode (use '--impure' to override)"
: "in restricted mode";
throw RestrictedPathError("access to absolute path '%1%' is forbidden %2%", abspath, modeInformation);
}
/* Resolve symlinks. */ /* Resolve symlinks. */
debug(format("checking access to '%s'") % abspath); debug(format("checking access to '%s'") % abspath);

5
tests/pure-eval.sh
View file

@ -6,7 +6,10 @@ nix eval --expr 'assert 1 + 2 == 3; true'
[[ $(nix eval --impure --expr 'builtins.readFile ./pure-eval.sh') =~ clearStore ]] [[ $(nix eval --impure --expr 'builtins.readFile ./pure-eval.sh') =~ clearStore ]]
(! nix eval --expr 'builtins.readFile ./pure-eval.sh') missingImpureErrorMsg=$(! nix eval --expr 'builtins.readFile ./pure-eval.sh' 2>&1)
echo "$missingImpureErrorMsg" | grep -q -- --impure || \
fail "The error message should mention the “--impure” flag to unblock users"
(! nix eval --expr builtins.currentTime) (! nix eval --expr builtins.currentTime)
(! nix eval --expr builtins.currentSystem) (! nix eval --expr builtins.currentSystem)