libstore/derivation-goal: Elaborate a TODO for performance concern

This commit is contained in:
Robert Hensing 2022-11-15 17:57:40 +01:00
parent 4bf70b74a7
commit bcd298d39b

View file

@ -538,7 +538,8 @@ void DerivationGoal::inputsRealised()
However, the impure derivations feature still relies on this
fragile way of doing things, because its builds do not have
a representation in the store, which is a usability problem
in itself */
in itself. When implementing this logic entirely with lookups
make sure that they're cached. */
if (auto outPath = get(inputDrvOutputs, { depDrvPath, j })) {
worker.store.computeFSClosure(*outPath, inputPaths);
}