Merge "libutil/config: fix appendable options not getting marked as overridden" into main

This commit is contained in:
alois31 2024-11-09 15:01:53 +00:00 committed by Gerrit Code Review
commit b967f1d5fe

View file

@ -64,8 +64,6 @@ void BaseSetting<T>::appendOrSet(T newValue, bool append, const ApplyConfigOptio
!trait::appendable,
"using default `appendOrSet` implementation with an appendable type");
assert(!append);
overridden = true;
value = std::move(newValue);
}
@ -77,6 +75,7 @@ void BaseSetting<T>::set(const std::string & str, bool append, const ApplyConfig
if (deprecated && (append || parsed != value)) {
warn("deprecated setting '%s' found (set to '%s')", name, str);
}
overridden = true;
appendOrSet(std::move(parsed), append, options);
} else {
assert(experimentalFeature);