lix-project/lix
20
58
Fork 31
Code Issues 353 Code Review (Gerrit) Projects 3 Releases Wiki Activity

throwTypeError with debugger/env

Browse source
This commit is contained in:
Ben Burdette 2021-05-10 18:36:57 -06:00
parent 2dd61411af
commit a8fef9a6b1
1 changed files with 85 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

123
src/libexpr/eval.cc
View file

@ -17,6 +17,7 @@
#include <sys/resource.h> #include <sys/resource.h>
#include <iostream> #include <iostream>
#include <fstream> #include <fstream>
#include <optional>
#include <sys/resource.h> #include <sys/resource.h>
@ -35,6 +36,7 @@
namespace nix { namespace nix {
std::function<void(const Error & error, const std::map<std::string, Value *> & env)> debuggerHook;
static char * dupString(const char * s) static char * dupString(const char * s)
{ {
@ -615,7 +617,6 @@ std::optional<EvalState::Doc> EvalState::getDoc(Value & v)
return {}; return {};
} }
/* Every "format" object (even temporary) takes up a few hundred bytes /* Every "format" object (even temporary) takes up a few hundred bytes
of stack space, which is a real killer in the recursive of stack space, which is a real killer in the recursive
evaluator. So here are some helper functions for throwing evaluator. So here are some helper functions for throwing
@ -656,22 +657,46 @@ LocalNoInlineNoReturn(void throwEvalError(const Pos & p1, const char * s, const
}); });
} }
LocalNoInlineNoReturn(void throwTypeError(const Pos & pos, const char * s)) // #define valmap(x) std::optional<const std::map<std::string, Value *>>
LocalNoInlineNoReturn(void throwTypeError(const Pos & pos, const char * s, const std::optional<const std::map<std::string, Value *>> & env))
{ {
throw TypeError({ auto error = TypeError({
.msg = hintfmt(s), .msg = hintfmt(s),
.errPos = pos .errPos = pos
}); });
if (debuggerHook)
debuggerHook(error, *env);
throw error;
} }
LocalNoInlineNoReturn(void throwTypeError(const Pos & pos, const char * s, const ExprLambda & fun, const Symbol & s2)) LocalNoInlineNoReturn(void throwTypeError(const Pos & pos, const char * s, const Value & v, const std::optional<const std::map<std::string, Value *>> & env))
{ {
throw TypeError({ auto error = TypeError({
.msg = hintfmt(s, v),
.errPos = pos
});
if (debuggerHook)
debuggerHook(error, *env);
throw error;
}
LocalNoInlineNoReturn(void throwTypeError(const Pos & pos, const char * s, const ExprLambda & fun, const Symbol & s2, const std::optional<const std::map<std::string, Value *>> & env))
{
auto error = TypeError({
.msg = hintfmt(s, fun.showNamePos(), s2), .msg = hintfmt(s, fun.showNamePos(), s2),
.errPos = pos .errPos = pos
}); });
if (debuggerHook)
debuggerHook(error, *env);
throw error;
} }
LocalNoInlineNoReturn(void throwAssertionError(const Pos & pos, const char * s, const string & s1)) LocalNoInlineNoReturn(void throwAssertionError(const Pos & pos, const char * s, const string & s1))
{ {
throw AssertionError({ throw AssertionError({
@ -688,12 +713,16 @@ LocalNoInlineNoReturn(void throwUndefinedVarError(const Pos & pos, const char *
}); });
} }
LocalNoInlineNoReturn(void throwMissingArgumentError(const Pos & pos, const char * s, const string & s1)) LocalNoInlineNoReturn(void throwMissingArgumentError(const Pos & pos, const char * s, const string & s1, const std::optional<const std::map<std::string, Value *>> & env))
{ {
throw MissingArgumentError({ auto error = MissingArgumentError({
.msg = hintfmt(s, s1), .msg = hintfmt(s, s1),
.errPos = pos .errPos = pos
}); });
if (debuggerHook)
debuggerHook(error, *env);
throw error;
} }
LocalNoInline(void addErrorTrace(Error & e, const char * s, const string & s2)) LocalNoInline(void addErrorTrace(Error & e, const char * s, const string & s2))
@ -1246,7 +1275,6 @@ void EvalState::callPrimOp(Value & fun, Value & arg, Value & v, const Pos & pos)
} }
} }
std::function<void(const Error & error, const std::map<std::string, Value *> & env)> debuggerHook;
void EvalState::callFunction(Value & fun, Value & arg, Value & v, const Pos & pos) void EvalState::callFunction(Value & fun, Value & arg, Value & v, const Pos & pos)
{ {
@ -1276,14 +1304,20 @@ void EvalState::callFunction(Value & fun, Value & arg, Value & v, const Pos & po
} }
if (!fun.isLambda()) { if (!fun.isLambda()) {
auto error = TypeError({ throwTypeError(
// .hint = hintfmt("attempt to call something which is not a function but %1%", showType(fun)), pos,
.msg = hintfmt("attempt to call something which is not a function but %1%", fun), "attempt to call something which is not a function but %1%",
.errPos = pos fun,
}); std::optional<const std::map<std::string, Value *>>({{"fun", &fun}, {"arg", &arg}}));
if (debuggerHook)
debuggerHook(error, {{"fun", &fun}, {"arg", &arg}}); // auto error = TypeError({
throw error; // // .hint = hintfmt("attempt to call something which is not a function but %1%", showType(fun)),
// .msg = hintfmt("attempt to call something which is not a function but %1%", fun),
// .errPos = pos
// });
// if (debuggerHook)
// debuggerHook(error, {{"fun", &fun}, {"arg", &arg}});
// throw error;
} }
ExprLambda & lambda(*fun.lambda.fun); ExprLambda & lambda(*fun.lambda.fun);
@ -1312,8 +1346,13 @@ void EvalState::callFunction(Value & fun, Value & arg, Value & v, const Pos & po
for (auto & i : lambda.formals->formals) { for (auto & i : lambda.formals->formals) {
Bindings::iterator j = arg.attrs->find(i.name); Bindings::iterator j = arg.attrs->find(i.name);
if (j == arg.attrs->end()) { if (j == arg.attrs->end()) {
if (!i.def) throwTypeError(pos, "%1% called without required argument '%2%'", if (!i.def)
lambda, i.name); throwTypeError(
pos,
"%1% called without required argument '%2%'",
lambda,
i.name,
std::optional<const std::map<std::string, Value *>>({{"fun", &fun}, {"arg", &arg}}));
env2.values[displ++] = i.def->maybeThunk(*this, env2); env2.values[displ++] = i.def->maybeThunk(*this, env2);
} else { } else {
attrsUsed++; attrsUsed++;
@ -1328,7 +1367,11 @@ void EvalState::callFunction(Value & fun, Value & arg, Value & v, const Pos & po
user. */ user. */
for (auto & i : *arg.attrs) for (auto & i : *arg.attrs)
if (lambda.formals->argNames.find(i.name) == lambda.formals->argNames.end()) if (lambda.formals->argNames.find(i.name) == lambda.formals->argNames.end())
throwTypeError(pos, "%1% called with unexpected argument '%2%'", lambda, i.name); throwTypeError(pos,
"%1% called with unexpected argument '%2%'",
lambda,
i.name,
std::optional<const std::map<std::string, Value *>>({{"fun", &fun}, {"arg", &arg}}));
abort(); // can't happen abort(); // can't happen
} }
} }
@ -1398,16 +1441,14 @@ void EvalState::autoCallFunction(Bindings & args, Value & fun, Value & res)
if (j != args.end()) { if (j != args.end()) {
actualArgs->attrs->push_back(*j); actualArgs->attrs->push_back(*j);
} else if (!i.def) { } else if (!i.def) {
auto error = MissingArgumentError({ throwMissingArgumentError(i.pos, R"(cannot evaluate a function that has an argument without a value ('%1%')
.msg = hintfmt(R"(cannot evaluate a function that has an argument without a value ('%1%')
Nix attempted to evaluate a function as a top level expression; in Nix attempted to evaluate a function as a top level expression; in
this case it must have its arguments supplied either by default this case it must have its arguments supplied either by default
values, or passed explicitly with '--arg' or '--argstr'. See values, or passed explicitly with '--arg' or '--argstr'. See
https://nixos.org/manual/nix/stable/#ss-functions.)", i.name), https://nixos.org/manual/nix/stable/#ss-functions.)", i.name,
.errPos = i.pos std::optional<const std::map<std::string, Value *>>({{"fun", &fun}})); // todo add bindings.
});
// throwMissingArgumentError(i.pos // throwMissingArgumentError(i.pos
// , R"(cannot evaluate a function that has an argument without a value ('%1%') // , R"(cannot evaluate a function that has an argument without a value ('%1%')
@ -1416,10 +1457,11 @@ https://nixos.org/manual/nix/stable/#ss-functions.)", i.name),
// values, or passed explicitly with '--arg' or '--argstr'. See // values, or passed explicitly with '--arg' or '--argstr'. See
// https://nixos.org/manual/nix/stable/#ss-functions.)", i.name); // https://nixos.org/manual/nix/stable/#ss-functions.)", i.name);
if (debuggerHook) // if (debuggerHook)
debuggerHook(error, {{"fun", &fun}}); // // debuggerHook(error, args);
// debuggerHook(error, {{"fun", &fun}});
throw error; // throw error;
} }
} }
@ -1673,7 +1715,8 @@ NixInt EvalState::forceInt(Value & v, const Pos & pos)
{ {
forceValue(v, pos); forceValue(v, pos);
if (v.type() != nInt) if (v.type() != nInt)
throwTypeError(pos, "value is %1% while an integer was expected", v); throwTypeError(pos, "value is %1% while an integer was expected", v,
std::optional<const std::map<std::string, Value *>>({{"value", &v}}));
return v.integer; return v.integer;
} }
@ -1684,7 +1727,8 @@ NixFloat EvalState::forceFloat(Value & v, const Pos & pos)
if (v.type() == nInt) if (v.type() == nInt)
return v.integer; return v.integer;
else if (v.type() != nFloat) else if (v.type() != nFloat)
throwTypeError(pos, "value is %1% while a float was expected", v); throwTypeError(pos, "value is %1% while a float was expected", v,
std::optional<const std::map<std::string, Value *>>({{"value", &v}}));
return v.fpoint; return v.fpoint;
} }
@ -1693,7 +1737,8 @@ bool EvalState::forceBool(Value & v, const Pos & pos)
{ {
forceValue(v, pos); forceValue(v, pos);
if (v.type() != nBool) if (v.type() != nBool)
throwTypeError(pos, "value is %1% while a Boolean was expected", v); throwTypeError(pos, "value is %1% while a Boolean was expected", v,
std::optional<const std::map<std::string, Value *>>({{"value", &v}}));
return v.boolean; return v.boolean;
} }
@ -1708,7 +1753,8 @@ void EvalState::forceFunction(Value & v, const Pos & pos)
{ {
forceValue(v, pos); forceValue(v, pos);
if (v.type() != nFunction && !isFunctor(v)) if (v.type() != nFunction && !isFunctor(v))
throwTypeError(pos, "value is %1% while a function was expected", v); throwTypeError(pos, "value is %1% while a function was expected", v,
std::optional<const std::map<std::string, Value *>>({{"value", &v}}));
} }
@ -1716,10 +1762,8 @@ string EvalState::forceString(Value & v, const Pos & pos)
{ {
forceValue(v, pos); forceValue(v, pos);
if (v.type() != nString) { if (v.type() != nString) {
if (pos) throwTypeError(pos, "value is %1% while a string was expected", v,
throwTypeError(pos, "value is %1% while a string was expected", v); std::optional<const std::map<std::string, Value *>>({{"value", &v}}));
else
throwTypeError("value is %1% while a string was expected", v);
} }
return string(v.string.s); return string(v.string.s);
} }
@ -1826,7 +1870,9 @@ string EvalState::coerceToString(const Pos & pos, Value & v, PathSet & context,
return *maybeString; return *maybeString;
} }
auto i = v.attrs->find(sOutPath); auto i = v.attrs->find(sOutPath);
if (i == v.attrs->end()) throwTypeError(pos, "cannot coerce a set to a string"); if (i == v.attrs->end())
throwTypeError(pos, "cannot coerce a set to a string",
std::optional<const std::map<std::string, Value *>>({{"value", &v}}));
return coerceToString(pos, *i->value, context, coerceMore, copyToStore); return coerceToString(pos, *i->value, context, coerceMore, copyToStore);
} }
@ -1857,7 +1903,8 @@ string EvalState::coerceToString(const Pos & pos, Value & v, PathSet & context,
} }
} }
throwTypeError(pos, "cannot coerce %1% to a string", v); throwTypeError(pos, "cannot coerce %1% to a string", v,
std::optional<const std::map<std::string, Value *>>({{"value", &v}}));
} }