lix-project/lix
20
57
Fork 31
Code Issues 347 Code Review (Gerrit) Projects 3 Releases Wiki Activity

* Re-use prepared statements across insertions into the manifest cache

Browse source 
DB.  This speeds up creating the cache from 16.1s to 7.9s on my
  system.
This commit is contained in:
Eelco Dolstra 2011-11-16 11:37:40 +00:00
parent c0b706213d
commit a5952405d2
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
perl/lib/Nix/Manifest.pm
View file

@ -286,6 +286,14 @@ EOF
open MAINLOCK, ">>$lockFile" or die "unable to acquire lock ‘$lockFile’: $!\n"; open MAINLOCK, ">>$lockFile" or die "unable to acquire lock ‘$lockFile’: $!\n";
flock(MAINLOCK, LOCK_EX) or die; flock(MAINLOCK, LOCK_EX) or die;
our $insertNAR = $dbh->prepare(
"insert into NARs(manifest, storePath, url, hash, size, narHash, " .
"narSize, refs, deriver, system) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)") or die;
our $insertPatch = $dbh->prepare(
"insert into Patches(manifest, storePath, basePath, baseHash, url, hash, " .
"size, narHash, narSize, patchType) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)");
$dbh->begin_work; $dbh->begin_work;
# Read each manifest in $manifestDir and add it to the database, # Read each manifest in $manifestDir and add it to the database,
@ -312,20 +320,16 @@ EOF
sub addNARToDB { sub addNARToDB {
my ($storePath, $narFile) = @_; my ($storePath, $narFile) = @_;
$dbh->do( $insertNAR->execute(
"insert into NARs(manifest, storePath, url, hash, size, narHash, " . $id, $storePath, $narFile->{url}, $narFile->{hash}, $narFile->{size},
"narSize, refs, deriver, system) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)",
{}, $id, $storePath, $narFile->{url}, $narFile->{hash}, $narFile->{size},
$narFile->{narHash}, $narFile->{narSize}, $narFile->{references}, $narFile->{narHash}, $narFile->{narSize}, $narFile->{references},
$narFile->{deriver}, $narFile->{system}); $narFile->{deriver}, $narFile->{system});
}; };
sub addPatchToDB { sub addPatchToDB {
my ($storePath, $patch) = @_; my ($storePath, $patch) = @_;
$dbh->do( $insertPatch->execute(
"insert into Patches(manifest, storePath, basePath, baseHash, url, hash, " . $id, $storePath, $patch->{basePath}, $patch->{baseHash}, $patch->{url},
"size, narHash, narSize, patchType) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)",
{}, $id, $storePath, $patch->{basePath}, $patch->{baseHash}, $patch->{url},
$patch->{hash}, $patch->{size}, $patch->{narHash}, $patch->{narSize}, $patch->{hash}, $patch->{size}, $patch->{narHash}, $patch->{narSize},
$patch->{patchType}); $patch->{patchType});
}; };