lix-project/lix
20
58
Fork 31
Code Issues 356 Code Review (Gerrit) Projects 3 Releases Wiki Activity

libstore: rename Goal::Finished::result to exitCode

Browse source 
the more useful type for `result` is BuildResult.

Change-Id: If93d9384e8d686eb63b33320f1d565f9b9afbf3a
This commit is contained in:
eldritch horrors 2024-08-30 19:01:30 +02:00
parent dc0cace604
commit a385c5935a
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/libstore/build/derivation-goal.cc
View file

@ -1549,7 +1549,7 @@ Goal::Finished DerivationGoal::done(
}
return Finished{
.result = buildResult.success() ? ecSuccess : ecFailed,
.exitCode = buildResult.success() ? ecSuccess : ecFailed,
.ex = ex ? std::make_shared<Error>(std::move(*ex)) : nullptr,
.permanentFailure = buildResult.status == BuildResult::PermanentFailure,
.timedOut = buildResult.status == BuildResult::TimedOut,

2
src/libstore/build/goal.hh
View file

@ -124,7 +124,7 @@ public:
bool inBuildSlot;
};
struct [[nodiscard]] Finished {
ExitCode result;
ExitCode exitCode;
std::shared_ptr<Error> ex;
bool permanentFailure = false;
bool timedOut = false;

10
src/libstore/build/worker.cc
View file

@ -156,7 +156,7 @@ void Worker::goalFinished(GoalPtr goal, Goal::Finished & f)
{
goal->trace("done");
assert(!goal->exitCode.has_value());
goal->exitCode = f.result;
goal->exitCode = f.exitCode;
goal->ex = f.ex;
permanentFailure |= f.permanentFailure;
@ -171,11 +171,11 @@ void Worker::goalFinished(GoalPtr goal, Goal::Finished & f)
waiting->trace(fmt("waitee '%s' done; %d left", goal->name, waiting->waitees.size()));
if (f.result != Goal::ecSuccess) ++waiting->nrFailed;
if (f.result == Goal::ecNoSubstituters) ++waiting->nrNoSubstituters;
if (f.result == Goal::ecIncompleteClosure) ++waiting->nrIncompleteClosure;
if (f.exitCode != Goal::ecSuccess) ++waiting->nrFailed;
if (f.exitCode == Goal::ecNoSubstituters) ++waiting->nrNoSubstituters;
if (f.exitCode == Goal::ecIncompleteClosure) ++waiting->nrIncompleteClosure;
if (waiting->waitees.empty() || (f.result == Goal::ecFailed && !settings.keepGoing)) {
if (waiting->waitees.empty() || (f.exitCode == Goal::ecFailed && !settings.keepGoing)) {
/* If we failed and keepGoing is not set, we remove all
remaining waitees. */
for (auto & i : waiting->waitees) {