lix-project/lix
20
57
Fork 31
Code Issues 349 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Merge pull request #1422 from nh2/fix-potential-hash-comparison-crash

Browse source 
Fix potential crash/wrong result two hashes of unequal length are compared
This commit is contained in:
Eelco Dolstra 2017-07-10 18:09:49 +02:00 committed by GitHub
parent 62a8fe6388 b591536e93
commit 9c00fa4179
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/libutil/hash.cc
View file

@ -45,6 +45,8 @@ bool Hash::operator != (const Hash & h2) const
bool Hash::operator < (const Hash & h) const bool Hash::operator < (const Hash & h) const
{ {
if (hashSize < h.hashSize) return true;
if (hashSize > h.hashSize) return false;
for (unsigned int i = 0; i < hashSize; i++) { for (unsigned int i = 0; i < hashSize; i++) {
if (hash[i] < h.hash[i]) return true; if (hash[i] < h.hash[i]) return true;
if (hash[i] > h.hash[i]) return false; if (hash[i] > h.hash[i]) return false;