lix-project/lix
20
58
Fork 31
Code Issues 359 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Merge pull request #7307 from hercules-ci/derivation-goal-improve-comment

Browse source 
libstore/derivation-goal: Elaborate a TODO for performance concern
This commit is contained in:
Théophane Hufschmitt 2023-01-06 13:07:57 +01:00 committed by GitHub
parent 420ccecc1e bcd298d39b
commit 8d88c3b347
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/libstore/build/derivation-goal.cc
View file

@ -544,7 +544,8 @@ void DerivationGoal::inputsRealised()
However, the impure derivations feature still relies on this However, the impure derivations feature still relies on this
fragile way of doing things, because its builds do not have fragile way of doing things, because its builds do not have
a representation in the store, which is a usability problem a representation in the store, which is a usability problem
in itself */ in itself. When implementing this logic entirely with lookups
make sure that they're cached. */
if (auto outPath = get(inputDrvOutputs, { depDrvPath, j })) { if (auto outPath = get(inputDrvOutputs, { depDrvPath, j })) {
worker.store.computeFSClosure(*outPath, inputPaths); worker.store.computeFSClosure(*outPath, inputPaths);
} }