lix-project/lix
19
52
Fork 27
Code Issues 341 Code Review (Gerrit) Projects 1 Releases Wiki Activity

Merge pull request #5636 from tweag/fix-use-after-free

Browse source 
Fix use after free in content-address.cc
This commit is contained in:
Eelco Dolstra 2021-11-24 12:11:00 +01:00 committed by GitHub
parent 585e97fa51 b26cb0c9ac
commit 6f4d1af971
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/libstore/content-address.cc
View file

@ -120,8 +120,10 @@ ContentAddress parseContentAddress(std::string_view rawCa) {
ContentAddressMethod parseContentAddressMethod(std::string_view caMethod) ContentAddressMethod parseContentAddressMethod(std::string_view caMethod)
{ {
std::string_view asPrefix {std::string{caMethod} + ":"}; std::string asPrefix = std::string{caMethod} + ":";
return parseContentAddressMethodPrefix(asPrefix); // parseContentAddressMethodPrefix takes its argument by reference
std::string_view asPrefixView = asPrefix;
return parseContentAddressMethodPrefix(asPrefixView);
} }
std::optional<ContentAddress> parseContentAddressOpt(std::string_view rawCaOpt) std::optional<ContentAddress> parseContentAddressOpt(std::string_view rawCaOpt)