lix-project/lix
20
58
Fork 31
Code Issues 359 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Merge "Expand comment on std::string operator+" into main

Browse source
This commit is contained in:
Rebecca Turner 2024-09-03 18:48:37 +00:00 committed by Gerrit Code Review
parent b7b1b9723f 9d8f433246
commit 644176a631
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/libutil/strings.hh
View file

@ -200,8 +200,18 @@ std::string showBytes(uint64_t bytes);
/**
* Provide an addition operator between strings and string_views
* Provide an addition operator between `std::string` and `std::string_view`
* inexplicably omitted from the standard library.
*
* > The reason for this is given in n3512 string_ref: a non-owning reference
* to a string, revision 2 by Jeffrey Yasskin:
* >
* > > I also omitted operator+(basic_string, basic_string_ref) because LLVM
* > > returns a lightweight object from this overload and only performs the
* > > concatenation lazily. If we define this overload, we'll have a hard time
* > > introducing that lightweight concatenation later.
*
* See: https://stackoverflow.com/a/47735624
*/
inline std::string operator + (const std::string & s1, std::string_view s2)
{