lix-project/lix
20
57
Fork 31
Code Issues 350 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Fix warning 'catching polymorphic type by value'

Browse source
This commit is contained in:
Eelco Dolstra 2023-09-01 14:49:49 +02:00
parent 3420b60b39
commit 5c95b32c46
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/libstore/build/create-derivation-and-realise-goal.cc
View file

@ -96,7 +96,7 @@ void CreateDerivationAndRealiseGoal::getDerivation()
auto drvPath = StorePath::dummy; auto drvPath = StorePath::dummy;
try { try {
drvPath = resolveDerivedPath(worker.store, *drvReq); drvPath = resolveDerivedPath(worker.store, *drvReq);
} catch (MissingRealisation) { } catch (MissingRealisation &) {
return std::nullopt; return std::nullopt;
} }
return worker.evalStore.isValidPath(drvPath) || worker.store.isValidPath(drvPath) return worker.evalStore.isValidPath(drvPath) || worker.store.isValidPath(drvPath)

2
src/libutil/util.cc
View file

@ -60,7 +60,7 @@ void initLibUtil() {
bool caught = false; bool caught = false;
try { try {
throwExceptionSelfCheck(); throwExceptionSelfCheck();
} catch (nix::Error _e) { } catch (const nix::Error & _e) {
caught = true; caught = true;
} }
// This is not actually the main point of this check, but let's make sure anyway: // This is not actually the main point of this check, but let's make sure anyway: