lix-project/lix
20
57
Fork 31
Code Issues 347 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Merge "unix-domain-socket.cc: add comment explaining why bindConnectProcHelper" into main

Browse source
This commit is contained in:
jade 2024-05-30 14:56:57 +00:00 committed by Gerrit Code Review
parent 3d78b4847e 26b3a1b9ce
commit 53d40888ff
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/libutil/unix-domain-socket.cc
View file

@ -37,6 +37,17 @@ AutoCloseFD createUnixDomainSocket(const Path & path, mode_t mode)
return fdSocket; return fdSocket;
} }
/**
* Workaround for the max length of Unix socket names being between 102
* (darwin) and 108 (Linux), which is extremely short. This limitation is
* caused by historical restrictions on sizeof(struct sockaddr):
* https://unix.stackexchange.com/a/367012.
*
* Our solution here is to start a process inheriting the socket, chdir into
* the directory of the socket, then connect with just the filename. This is
* rather silly but it works around working directory being process-wide state,
* and is as clearly sound as possible.
*/
static void bindConnectProcHelper( static void bindConnectProcHelper(
std::string_view operationName, auto && operation, std::string_view operationName, auto && operation,
int fd, const std::string & path) int fd, const std::string & path)