lix-project/lix
20
55
Fork 31
Code Issues 346 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Clarify comment on sandbox and temp fresh paths

Browse source
This commit is contained in:
John Ericson 2020-08-11 22:46:05 +00:00
parent 6d57139050
commit 4c6aac8fdf
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/libstore/build.cc
View file

@ -2370,9 +2370,11 @@ void DerivationGoal::startBuilder()
(typically the dependencies of /bin/sh). Throw them
out. */
for (auto & i : drv->outputs) {
/* If the name isn't known a priori (i.e. floating content-addressed
derivation), the temporary location we use should be fresh and
never in the sandbox in the first place. */
/* If the name isn't known a priori (i.e. floating
content-addressed derivation), the temporary location we use
should be fresh. Freshness means it is impossible that the path
is already in the sandbox, so we don't need to worry about
removing it. */
auto optPath = i.second.pathOpt(worker.store, drv->name);
if (optPath)
dirsInChroot.erase(worker.store.printStorePath(*optPath));