lix-project/lix
20
55
Fork 31
Code Issues 345 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Fill in missing comparison operators for content addresses

Browse source
This commit is contained in:
John Ericson 2022-03-25 22:40:40 +00:00
parent 0dc2974930
commit 2c21cb6720
1 changed files with 12 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/libstore/content-address.hh
View file

@ -3,6 +3,7 @@
#include <variant> #include <variant>
#include "hash.hh" #include "hash.hh"
#include "path.hh" #include "path.hh"
#include "comparator.hh"
namespace nix { namespace nix {
@ -46,6 +47,8 @@ std::string renderContentAddressMethod(ContentAddressMethod caMethod);
struct TextHash { struct TextHash {
Hash hash; Hash hash;
GENERATE_CMP(TextHash, me->hash);
}; };
/// Pair of a hash, and how the file system was ingested /// Pair of a hash, and how the file system was ingested
@ -53,6 +56,8 @@ struct FixedOutputHash {
FileIngestionMethod method; FileIngestionMethod method;
Hash hash; Hash hash;
std::string printMethodAlgo() const; std::string printMethodAlgo() const;
GENERATE_CMP(FixedOutputHash, me->method, me->hash);
}; };
/* /*
@ -91,17 +96,13 @@ struct PathReferences
std::set<Ref> references; std::set<Ref> references;
bool hasSelfReference = false; bool hasSelfReference = false;
bool operator == (const PathReferences<Ref> & other) const
{
return references == other.references
&& hasSelfReference == other.hasSelfReference;
}
/* Functions to view references + hasSelfReference as one set, mainly for /* Functions to view references + hasSelfReference as one set, mainly for
compatibility's sake. */ compatibility's sake. */
StorePathSet referencesPossiblyToSelf(const Ref & self) const; StorePathSet referencesPossiblyToSelf(const Ref & self) const;
void insertReferencePossiblyToSelf(const Ref & self, Ref && ref); void insertReferencePossiblyToSelf(const Ref & self, Ref && ref);
void setReferencesPossiblyToSelf(const Ref & self, std::set<Ref> && refs); void setReferencesPossiblyToSelf(const Ref & self, std::set<Ref> && refs);
GENERATE_CMP(PathReferences<Ref>, me->references, me->hasSelfReference);
}; };
template<typename Ref> template<typename Ref>
@ -142,11 +143,15 @@ void PathReferences<Ref>::setReferencesPossiblyToSelf(const Ref & self, std::set
struct TextInfo : TextHash { struct TextInfo : TextHash {
// References for the paths, self references disallowed // References for the paths, self references disallowed
StorePathSet references; StorePathSet references;
GENERATE_CMP(TextInfo, *(const TextHash *)me, me->references);
}; };
struct FixedOutputInfo : FixedOutputHash { struct FixedOutputInfo : FixedOutputHash {
// References for the paths // References for the paths
PathReferences<StorePath> references; PathReferences<StorePath> references;
GENERATE_CMP(FixedOutputInfo, *(const FixedOutputHash *)me, me->references);
}; };
typedef std::variant< typedef std::variant<
@ -160,17 +165,7 @@ struct StorePathDescriptor {
std::string name; std::string name;
ContentAddressWithReferences info; ContentAddressWithReferences info;
bool operator == (const StorePathDescriptor & other) const GENERATE_CMP(StorePathDescriptor, me->name, me->info);
{
return name == other.name;
// FIXME second field
}
bool operator < (const StorePathDescriptor & other) const
{
return name < other.name;
// FIXME second field
}
}; };
} }