lix-project/lix
20
55
Fork 31
Code Issues 344 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Inline newFunction

Browse source
This commit is contained in:
Carlo Nucera 2020-07-02 10:58:29 -04:00
parent 343d1569b1
commit 27c8029573
1 changed files with 8 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/libutil/hash.cc
View file

@ -149,11 +149,12 @@ Hash Hash::parseAnyPrefixed(std::string_view s)
return parseAny(s, std::nullopt);
}
static std::pair<HashType, bool> newFunction(std::string_view & rest, std::optional<HashType> optType)
Hash Hash::parseAny(std::string_view original, std::optional<HashType> optType)
{
auto original = rest;
auto rest = original;
bool isSRI = false;
HashType hashType;
// Parse the has type before the separater, if there was one.
std::optional<HashType> optParsedType;
@ -171,23 +172,13 @@ static std::pair<HashType, bool> newFunction(std::string_view & rest, std::optio
// Either the string or user must provide the type, if they both do they
// must agree.
if (!optParsedType && !optType) {
if (!optParsedType && !optType)
throw BadHash("hash '%s' does not include a type, nor is the type otherwise known from context.", rest);
} else {
if (optParsedType && optType && *optParsedType != *optType)
else if (optParsedType && optType && *optParsedType != *optType)
throw BadHash("hash '%s' should have type '%s'", original, printHashType(*optType));
return {
optParsedType ? *optParsedType : *optType,
isSRI,
};
}
}
// mutates the string_view
Hash Hash::parseAny(std::string_view original, std::optional<HashType> optType)
{
auto typeAndSRI = newFunction(original, optType);
return Hash(original, typeAndSRI);
hashType = optParsedType ? *optParsedType : *optType;
return Hash(rest, std::make_pair(hashType, isSRI));
}
Hash::Hash(std::string_view rest, std::pair<HashType, bool> typeAndSRI)