lix-project/lix
20
57
Fork 31
Code Issues 350 Code Review (Gerrit) Projects 3 Releases Wiki Activity

libexpr: unbreak PosTable performance

Browse source 
this was mostly an inconvenience for error reporting, but fully broke
the debugger (because the debugger does *a lot* of eager position
resolution). copying the line offsets into a local and filling that
local when empty without also storing the calculated offsets back does
kind of ... not cache anything.

fixes #165

Change-Id: Iccb0ba193ce2f15c832978daecf7b9bebbbe8585
This commit is contained in:
eldritch horrors 2024-03-20 13:45:36 +01:00
parent 5a28d70d1e
commit 22e3f0e987
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/libexpr/nixexpr.cc
View file

@ -593,7 +593,7 @@ Pos PosTable::operator[](PosIdx p) const
Pos result{0, 0, origin->origin}; Pos result{0, 0, origin->origin};
auto lines = this->lines.lock(); auto lines = this->lines.lock();
auto linesForInput = (*lines)[origin->offset]; auto & linesForInput = (*lines)[origin->offset];
if (linesForInput.empty()) { if (linesForInput.empty()) {
auto source = result.getSource().value_or(""); auto source = result.getSource().value_or("");