Merge pull request #10074 from lf-/jade/ban-implicit-fallthrough

Warn on implicit switch case fallthrough

(cherry picked from commit 21282c3c204597641402c6bcff8fc9ee7bc31fa1)
Change-Id: I5ebbdfb6c037d2c55254f37dd391c07c2ce7443e

Makefile

@@ -68,4 +68,4 @@ endif
 
 include mk/lib.mk
 
-GLOBAL_CXXFLAGS += -g -Wall -include $(buildprefix)config.h -std=c++2a -I src
+GLOBAL_CXXFLAGS += -g -Wall -Wimplicit-fallthrough -include $(buildprefix)config.h -std=c++2a -I src

src/libexpr/lexer.l

@@ -20,6 +20,12 @@
 #pragma clang diagnostic ignored "-Wunneeded-internal-declaration"
 #endif
 
+// yacc generates code that uses unannotated fallthrough.
+#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
+#ifdef __clang__
+#pragma clang diagnostic ignored "-Wimplicit-fallthrough"
+#endif
+
 #include <boost/lexical_cast.hpp>
 
 #include "nixexpr.hh"

tests/unit/libstore-support/tests/path.cc

@@ -33,6 +33,7 @@ Gen<StorePathName> Arbitrary<StorePathName>::arbitrary()
         switch (auto i = *gen::inRange<uint8_t>(0, 10 + 2 * 26 + 6)) {
             case 0 ... 9:
                 pre += '0' + i;
+                break;
             case 10 ... 35:
                 pre += 'A' + (i - 10);
                 break;
@@ -52,6 +53,7 @@ Gen<StorePathName> Arbitrary<StorePathName>::arbitrary()
                     pre += '.';
                     break;
                 }
+                [[fallthrough]];
             case 65:
                 pre += '_';
                 break;