lix-project/lix
20
55
Fork 31
Code Issues 344 Code Review (Gerrit) Projects 3 Releases Wiki Activity

Remove comments claiming we use a private PID namespace

Browse source 
This is no longer the case since
524f89f139.
This commit is contained in:
Eelco Dolstra 2014-10-29 15:49:03 +01:00
parent 5f7ded7d22
commit 11aef17a77
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/libstore/build.cc
View file

@ -1926,12 +1926,6 @@ void DerivationGoal::initChild()
/* Set up private namespaces for the build: /* Set up private namespaces for the build:
- The PID namespace causes the build to start as PID 1.
Processes outside of the chroot are not visible to
those on the inside, but processes inside the chroot
are visible from the outside (though with different
PIDs).
- The private mount namespace ensures that all the bind - The private mount namespace ensures that all the bind
mounts we do will only show up in this process and mounts we do will only show up in this process and
its children, and will disappear automatically when its children, and will disappear automatically when
@ -2032,8 +2026,7 @@ void DerivationGoal::initChild()
throw SysError(format("bind mount from ‘%1%’ to ‘%2%’ failed") % source % target); throw SysError(format("bind mount from ‘%1%’ to ‘%2%’ failed") % source % target);
} }
/* Bind a new instance of procfs on /proc to reflect our /* Bind a new instance of procfs on /proc. */
private PID namespace. */
createDirs(chrootRootDir + "/proc"); createDirs(chrootRootDir + "/proc");
if (mount("none", (chrootRootDir + "/proc").c_str(), "proc", 0, 0) == -1) if (mount("none", (chrootRootDir + "/proc").c_str(), "proc", 0, 0) == -1)
throw SysError("mounting /proc"); throw SysError("mounting /proc");