From 092af3c82692cb346dfac0dcb1bafe46703682ca Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Thu, 5 Dec 2019 18:23:32 +0100 Subject: [PATCH] Eliminate more pass-by-value in variadic calls --- src/libutil/types.hh | 6 +++--- src/libutil/util.hh | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libutil/types.hh b/src/libutil/types.hh index 5d3e76421..20b96a85c 100644 --- a/src/libutil/types.hh +++ b/src/libutil/types.hh @@ -97,14 +97,14 @@ public: unsigned int status = 1; // exit status template - BaseError(unsigned int status, Args... args) + BaseError(unsigned int status, const Args & ... args) : err(fmt(args...)) , status(status) { } template - BaseError(Args... args) + BaseError(const Args & ... args) : err(fmt(args...)) { } @@ -136,7 +136,7 @@ public: int errNo; template - SysError(Args... args) + SysError(const Args & ... args) : Error(addErrno(fmt(args...))) { } diff --git a/src/libutil/util.hh b/src/libutil/util.hh index b9f9ea882..a1acb49b5 100644 --- a/src/libutil/util.hh +++ b/src/libutil/util.hh @@ -299,7 +299,7 @@ public: int status; template - ExecError(int status, Args... args) + ExecError(int status, const Args & ... args) : Error(args...), status(status) { } };