lix-project/lix
20
57
Fork 31
Code Issues 347 Code Review (Gerrit) Projects 3 Releases Wiki Activity

* Lock the database during updates.

Browse source
This commit is contained in:
Eelco Dolstra 2011-04-11 12:40:13 +00:00
parent b2c11b9ed0
commit 08c8971498
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scripts/NixManifest.pm.in
View file

@ -3,6 +3,7 @@ use DBI;
use Cwd;
use File::stat;
use File::Path;
use Fcntl ':flock';
sub addPatch {
@ -259,7 +260,11 @@ EOF
$dbh->do("create index if not exists Patches_storePath on Patches(storePath)");
# !!! locking?
# Acquire an exclusive lock to ensure that only one process
# updates the DB at the same time. This isn't really necessary,
# but it prevents work duplication and lock contention in SQLite.
open MAINLOCK, ">>$manifestDir/cache.lock" or die;
flock(MAINLOCK, LOCK_EX) or die;
# Read each manifest in $manifestDir and add it to the database,
# unless we've already done so on a previous run.
@ -326,6 +331,8 @@ EOF
$dbh->commit;
close MAINLOCK;
return $dbh;
}