lix/tests/unit/libexpr-support/local.mk

libraries += libexpr-test-support

libexpr-test-support_NAME = libnixexpr-test-support

libexpr-test-support_DIR := $(d)

libexpr-test-support_INSTALL_DIR :=

libexpr-test-support_SOURCES := \
    $(wildcard $(d)/tests/*.cc) \
    $(wildcard $(d)/tests/value/*.cc)

libexpr-test-support_CXXFLAGS += $(libexpr-tests_EXTRA_INCLUDES)

libexpr-test-support_LIBS = \
    libstore-test-support libutil-test-support \
    libexpr libstore libutil

libexpr-test-support_LDFLAGS := -pthread -lrapidcheck
Move tests to separate directories, and document Today, with the tests inside a `tests` intermingled with the corresponding library's source code, we have a few problems: - We have to be careful that wildcards don't end up with tests being built as part of Nix proper, or test headers being installed as part of Nix proper. - Tests in libraries but not executables is not right: - It means each executable runs the previous unit tests again, because it needs the libraries. - It doesn't work right on Windows, which doesn't want you to load a DLL just for the side global variable . It could be made to work with the dlopen equivalent, but that's gross! This reorg solves these problems. There is a remaining problem which is that sibbling headers (like `hash.hh` the test header vs `hash.hh` the main `libnixutil` header) end up shadowing each other. This PR doesn't solve that. That is left as future work for a future PR. Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io> (cherry picked from commit 91b6833686a6a6d9eac7f3f66393ec89ef1d3b57) (cherry picked from commit a61e42adb528b3d40ce43e07c79368d779a8b624) 2023-08-25 14:20:28 +00:00			`libraries += libexpr-test-support`

			`libexpr-test-support_NAME = libnixexpr-test-support`

			`libexpr-test-support_DIR := $(d)`

			`libexpr-test-support_INSTALL_DIR :=`

			`libexpr-test-support_SOURCES := \`
			`$(wildcard $(d)/tests/*.cc) \`
			`$(wildcard $(d)/tests/value/*.cc)`

			`libexpr-test-support_CXXFLAGS += $(libexpr-tests_EXTRA_INCLUDES)`

			`libexpr-test-support_LIBS = \`
			`libstore-test-support libutil-test-support \`
			`libexpr libstore libutil`

Add missing `-pthread` for test support libraries This is good in general (see how the other libraries also have long had it, since 49fe9592a47e7819179c2de4fd6068e897e944c7) but in particular needed to fix the NetBSD build. (cherry picked from commit b23273f6a29c725646b3523b1c35a0ae4a84ef61) 2023-12-05 23:10:37 +00:00			`libexpr-test-support_LDFLAGS := -pthread -lrapidcheck`