lix-project/lix-website
3
1
Fork 14
Code Issues 3 Pull requests 5 Packages Projects Releases Wiki Activity

add-to-config, about: fix typos #10

Merged
raito merged 2 commits from danderson/lix-website:dave/typos into main 2024-06-09 13:08:46 +00:00
Conversation 0 Commits 2 Files changed 2 +3 -3
danderson commented 2024-05-06 05:39:22 +00:00
Contributor
Copy link
No description provided.
danderson added 2 commits 2024-05-06 05:39:26 +00:00
danderson reviewed 2024-05-06 07:12:17 +00:00
content/add-to-config.md Outdated
@ -83,7 +83,7 @@ Add the following to any NixOS module in your configuration (e.g. `configuration
```nix
{
nix.settings.extra-substituters = [
danderson commented 2024-05-06 07:12:17 +00:00
Author
Contributor
Copy link

I was confused: https://nixos.org/manual/nix/stable/command-ref/conf-file#file-format shows that both extra-substituters and substituters work, extra-... means "append to list instead of replacing"

The NixOS module for Nix configuration only defines the non-extra variant, and the normal list merge semantics end up behaving like extra-substituters (with the addition that the nixos module automatically adds cache.nixos.org to the list as well).

So, I think my change does the right thing in the context of the nixos module, by using nixlang's list combination logic rather than deferring to nix.conf load time... But I'm also happy to drop this commit out of the PR if you prefer.

I was confused: https://nixos.org/manual/nix/stable/command-ref/conf-file#file-format shows that both `extra-substituters` and `substituters` work, `extra-...` means "append to list instead of replacing" The NixOS module for Nix configuration only defines the non-extra variant, and the normal list merge semantics end up behaving like extra-substituters (with the addition that the nixos module automatically adds cache.nixos.org to the list as well). So, I _think_ my change does the right thing in the context of the nixos module, by using nixlang's list combination logic rather than deferring to nix.conf load time... But I'm also happy to drop this commit out of the PR if you prefer.
raito commented 2024-06-09 13:07:56 +00:00
Owner
Copy link

Seems good to me.

Seems good to me.
raito marked this conversation as resolved
raito approved these changes 2024-06-09 13:08:06 +00:00
raito force-pushed dave/typos from 8f5ecc070f to 91cc630e23 2024-06-09 13:08:20 +00:00 Compare
raito merged commit c533c9eaf8 into main 2024-06-09 13:08:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
raito
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix-website#10
No description provided.
Delete branch "danderson/lix-website:dave/typos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?