5985b8b527
When adding a path to the local store (via `LocalStore::addToStore`), ensure that the `ca` field of the provided `ValidPathInfo` does indeed correspond to the content of the path. Otherwise any untrusted user (or any binary cache) can add arbitrary content-addressed paths to the store (as content-addressed paths don’t need a signature).
38 lines
979 B
Bash
38 lines
979 B
Bash
source common.sh
|
||
|
||
BINARY_CACHE=file://$cacheDir
|
||
|
||
getHash() {
|
||
basename "$1" | cut -d '-' -f 1
|
||
}
|
||
getRemoteNarInfo () {
|
||
echo "$cacheDir/$(getHash "$1").narinfo"
|
||
}
|
||
|
||
cat <<EOF > $TEST_HOME/good.txt
|
||
I’m a good path
|
||
EOF
|
||
|
||
cat <<EOF > $TEST_HOME/bad.txt
|
||
I’m a bad path
|
||
EOF
|
||
|
||
good=$(nix-store --add $TEST_HOME/good.txt)
|
||
bad=$(nix-store --add $TEST_HOME/bad.txt)
|
||
nix copy --to "$BINARY_CACHE" "$good"
|
||
nix copy --to "$BINARY_CACHE" "$bad"
|
||
nix-collect-garbage >/dev/null 2>&1
|
||
|
||
# Falsifying the narinfo file for '$good'
|
||
goodPathNarInfo=$(getRemoteNarInfo "$good")
|
||
badPathNarInfo=$(getRemoteNarInfo "$bad")
|
||
for fieldName in URL FileHash FileSize NarHash NarSize; do
|
||
sed -i "/^$fieldName/d" "$goodPathNarInfo"
|
||
grep -E "^$fieldName" "$badPathNarInfo" >> "$goodPathNarInfo"
|
||
done
|
||
|
||
# Copying back '$good' from the binary cache. This should fail as it is
|
||
# corrupted
|
||
if nix copy --from "$BINARY_CACHE" "$good"; then
|
||
fail "Importing a path with a wrong CA field should fail"
|
||
fi
|