c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
24 lines
876 B
Bash
24 lines
876 B
Bash
source common.sh
|
|
|
|
clearStore
|
|
|
|
cp ./dependencies.nix ./dependencies.builder0.sh ./config.nix $TEST_HOME
|
|
|
|
cd $TEST_HOME
|
|
|
|
nix why-depends --derivation --file ./dependencies.nix input2_drv input1_drv
|
|
nix why-depends --file ./dependencies.nix input2_drv input1_drv
|
|
|
|
nix-build ./dependencies.nix -A input0_drv -o dep
|
|
nix-build ./dependencies.nix -o toplevel
|
|
|
|
FAST_WHY_DEPENDS_OUTPUT=$(nix why-depends ./toplevel ./dep)
|
|
PRECISE_WHY_DEPENDS_OUTPUT=$(nix why-depends ./toplevel ./dep --precise)
|
|
|
|
# Both outputs should show that `input-2` is in the dependency chain
|
|
echo "$FAST_WHY_DEPENDS_OUTPUT" | grepQuiet input-2
|
|
echo "$PRECISE_WHY_DEPENDS_OUTPUT" | grepQuiet input-2
|
|
|
|
# But only the “precise” one should refer to `reference-to-input-2`
|
|
echo "$FAST_WHY_DEPENDS_OUTPUT" | grepQuietInverse reference-to-input-2
|
|
echo "$PRECISE_WHY_DEPENDS_OUTPUT" | grepQuiet reference-to-input-2
|