lix-releng-staging/tests/ca
John Ericson c11836126b Harden tests' bash
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.

 - `set -u` catches the use of undefined variables
 - `set -o pipefail` catches failures (like `set -e`) earlier in the
   pipeline.

This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.

There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.

To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.

`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.

`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.

`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-03-08 10:26:30 -05:00
..
build-dry.sh Fix nix build --dry-run with CA derivations 2022-03-17 11:55:19 +01:00
build-with-garbage-path.sh Non-blocking garbage collector 2021-10-13 12:12:44 +02:00
build.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
common.sh tests: remove 'ca-references' feature 2022-04-21 10:06:39 +02:00
concurrent-builds.sh Allow running all the tests with the daemon 2021-07-27 17:06:11 +02:00
config.nix.in Add a test for nix run with CA derivations 2021-05-17 15:10:48 +02:00
content-addressed.nix Enable/fix tests in nix-static 2022-06-22 23:33:15 +02:00
duplicate-realisation-in-closure.sh tests/common.sh.in: Add enableFeatures helper 2022-03-02 21:48:25 +01:00
flake.nix Add a test for nix run with CA derivations 2021-05-17 15:10:48 +02:00
gc.sh Allow running all the tests with the daemon 2021-07-27 17:06:11 +02:00
import-derivation.sh Fix IFD with CA derivations 2021-12-21 09:36:50 +01:00
new-build-cmd.sh Test nix build --json return output paths in floating CA case 2023-02-10 18:04:13 -05:00
nix-copy.sh tests/common.sh.in: Add enableFeatures helper 2022-03-02 21:48:25 +01:00
nix-run.sh tests/common.sh.in: Add enableFeatures helper 2022-03-02 21:48:25 +01:00
nix-shell.sh tests/common.sh.in: Add enableFeatures helper 2022-03-02 21:48:25 +01:00
nondeterministic.nix Add a test for the “two glibc” issue 2021-06-23 11:18:31 +02:00
post-hook.sh tests/common.sh.in: Add enableFeatures helper 2022-03-02 21:48:25 +01:00
racy.nix Properly lock the builds of CA derivations 2021-07-20 06:57:56 +02:00
recursive.sh Test nix build --json return output paths in floating CA case 2023-02-10 18:04:13 -05:00
repl.sh Fix nix repl’s building of CA derivations 2021-11-05 11:04:14 +01:00
selfref-gc.sh tests: remove 'ca-references' feature 2022-04-21 10:06:39 +02:00
signatures.sh tests/common.sh.in: Add enableFeatures helper 2022-03-02 21:48:25 +01:00
substitute.sh Get rid of .drv special-casing for store path installables 2023-02-28 17:07:05 -05:00
why-depends.sh add explanation and test 2022-11-23 12:06:47 -05:00