c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
89 lines
3.4 KiB
Bash
89 lines
3.4 KiB
Bash
source common.sh
|
||
|
||
clearStore
|
||
|
||
rm -f $TEST_ROOT/result*
|
||
|
||
# Test whether the output names match our expectations
|
||
outPath=$(nix-instantiate multiple-outputs.nix --eval -A nameCheck.out.outPath)
|
||
[ "$(echo "$outPath" | sed -E 's_^".*/[^-/]*-([^/]*)"$_\1_')" = "multiple-outputs-a" ]
|
||
outPath=$(nix-instantiate multiple-outputs.nix --eval -A nameCheck.dev.outPath)
|
||
[ "$(echo "$outPath" | sed -E 's_^".*/[^-/]*-([^/]*)"$_\1_')" = "multiple-outputs-a-dev" ]
|
||
|
||
# Test whether read-only evaluation works when referring to the
|
||
# ‘drvPath’ attribute.
|
||
echo "evaluating c..."
|
||
#drvPath=$(nix-instantiate multiple-outputs.nix -A c --readonly-mode)
|
||
|
||
# And check whether the resulting derivation explicitly depends on all
|
||
# outputs.
|
||
drvPath=$(nix-instantiate multiple-outputs.nix -A c)
|
||
#[ "$drvPath" = "$drvPath2" ]
|
||
grepQuiet 'multiple-outputs-a.drv",\["first","second"\]' $drvPath
|
||
grepQuiet 'multiple-outputs-b.drv",\["out"\]' $drvPath
|
||
|
||
# While we're at it, test the ‘unsafeDiscardOutputDependency’ primop.
|
||
outPath=$(nix-build multiple-outputs.nix -A d --no-out-link)
|
||
drvPath=$(cat $outPath/drv)
|
||
outPath=$(nix-store -q $drvPath)
|
||
(! [ -e "$outPath" ])
|
||
|
||
# Do a build of something that depends on a derivation with multiple
|
||
# outputs.
|
||
echo "building b..."
|
||
outPath=$(nix-build multiple-outputs.nix -A b --no-out-link)
|
||
echo "output path is $outPath"
|
||
[ "$(cat "$outPath"/file)" = "success" ]
|
||
|
||
# Test nix-build on a derivation with multiple outputs.
|
||
outPath1=$(nix-build multiple-outputs.nix -A a -o $TEST_ROOT/result)
|
||
[ -e $TEST_ROOT/result-first ]
|
||
(! [ -e $TEST_ROOT/result-second ])
|
||
nix-build multiple-outputs.nix -A a.all -o $TEST_ROOT/result
|
||
[ "$(cat $TEST_ROOT/result-first/file)" = "first" ]
|
||
[ "$(cat $TEST_ROOT/result-second/file)" = "second" ]
|
||
[ "$(cat $TEST_ROOT/result-second/link/file)" = "first" ]
|
||
hash1=$(nix-store -q --hash $TEST_ROOT/result-second)
|
||
|
||
outPath2=$(nix-build $(nix-instantiate multiple-outputs.nix -A a) --no-out-link)
|
||
[[ $outPath1 = $outPath2 ]]
|
||
|
||
outPath2=$(nix-build $(nix-instantiate multiple-outputs.nix -A a.first) --no-out-link)
|
||
[[ $outPath1 = $outPath2 ]]
|
||
|
||
outPath2=$(nix-build $(nix-instantiate multiple-outputs.nix -A a.second) --no-out-link)
|
||
[[ $(cat $outPath2/file) = second ]]
|
||
|
||
[[ $(nix-build $(nix-instantiate multiple-outputs.nix -A a.all) --no-out-link | wc -l) -eq 2 ]]
|
||
|
||
# Delete one of the outputs and rebuild it. This will cause a hash
|
||
# rewrite.
|
||
env -u NIX_REMOTE nix store delete $TEST_ROOT/result-second --ignore-liveness
|
||
nix-build multiple-outputs.nix -A a.all -o $TEST_ROOT/result
|
||
[ "$(cat $TEST_ROOT/result-second/file)" = "second" ]
|
||
[ "$(cat $TEST_ROOT/result-second/link/file)" = "first" ]
|
||
hash2=$(nix-store -q --hash $TEST_ROOT/result-second)
|
||
[ "$hash1" = "$hash2" ]
|
||
|
||
# Make sure that nix-build works on derivations with multiple outputs.
|
||
echo "building a.first..."
|
||
nix-build multiple-outputs.nix -A a.first --no-out-link
|
||
|
||
# Cyclic outputs should be rejected.
|
||
echo "building cyclic..."
|
||
if nix-build multiple-outputs.nix -A cyclic --no-out-link; then
|
||
echo "Cyclic outputs incorrectly accepted!"
|
||
exit 1
|
||
fi
|
||
|
||
# Do a GC. This should leave an empty store.
|
||
echo "collecting garbage..."
|
||
rm $TEST_ROOT/result*
|
||
nix-store --gc --keep-derivations --keep-outputs
|
||
nix-store --gc --print-roots
|
||
rm -rf $NIX_STORE_DIR/.links
|
||
rmdir $NIX_STORE_DIR
|
||
|
||
expect 1 nix build -f multiple-outputs.nix invalid-output-name-1 2>&1 | grep 'contains illegal character'
|
||
expect 1 nix build -f multiple-outputs.nix invalid-output-name-2 2>&1 | grep 'contains illegal character'
|