c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
46 lines
1.8 KiB
Bash
46 lines
1.8 KiB
Bash
source common.sh
|
|
|
|
clearStore
|
|
clearCache
|
|
|
|
(( $(nix search -f search.nix '' hello | wc -l) > 0 ))
|
|
|
|
# Check descriptions are searched
|
|
(( $(nix search -f search.nix '' broken | wc -l) > 0 ))
|
|
|
|
# Check search that matches nothing
|
|
(( $(nix search -f search.nix '' nosuchpackageexists | wc -l) == 0 ))
|
|
|
|
# Search for multiple arguments
|
|
(( $(nix search -f search.nix '' hello empty | wc -l) == 2 ))
|
|
|
|
# Multiple arguments will not exist
|
|
(( $(nix search -f search.nix '' hello broken | wc -l) == 0 ))
|
|
|
|
## Search expressions
|
|
|
|
# Check that empty search string matches all
|
|
nix search -f search.nix '' |grepQuiet foo
|
|
nix search -f search.nix '' |grepQuiet bar
|
|
nix search -f search.nix '' |grepQuiet hello
|
|
|
|
## Tests for multiple regex/match highlighting
|
|
|
|
e=$'\x1b' # grep doesn't support \e, \033 or even \x1b
|
|
# Multiple overlapping regexes
|
|
(( $(nix search -f search.nix '' 'oo' 'foo' 'oo' | grep -c "$e\[32;1mfoo$e\\[0;1m") == 1 ))
|
|
(( $(nix search -f search.nix '' 'broken b' 'en bar' | grep -c "$e\[32;1mbroken bar$e\\[0m") == 1 ))
|
|
|
|
# Multiple matches
|
|
# Searching for 'o' should yield the 'o' in 'broken bar', the 'oo' in foo and 'o' in hello
|
|
(( $(nix search -f search.nix '' 'o' | grep -Eoc "$e\[32;1mo{1,2}$e\[(0|0;1)m") == 3 ))
|
|
# Searching for 'b' should yield the 'b' in bar and the two 'b's in 'broken bar'
|
|
# NOTE: This does not work with `grep -c` because it counts the two 'b's in 'broken bar' as one matched line
|
|
(( $(nix search -f search.nix '' 'b' | grep -Eo "$e\[32;1mb$e\[(0|0;1)m" | wc -l) == 3 ))
|
|
|
|
## Tests for --exclude
|
|
(( $(nix search -f search.nix -e hello | grep -c hello) == 0 ))
|
|
|
|
(( $(nix search -f search.nix foo --exclude 'foo|bar' | grep -Ec 'foo|bar') == 0 ))
|
|
(( $(nix search -f search.nix foo -e foo --exclude bar | grep -Ec 'foo|bar') == 0 ))
|
|
[[ $(nix search -f search.nix -e bar --json | jq -c 'keys') == '["foo","hello"]' ]]
|