lix-releng-staging/src/libexpr
Tuomas Tynkkynen 2cd468874f Include config.h implicitly with '-include config.h' in CFLAGS
Because config.h can #define things like _FILE_OFFSET_BITS=64 and not
every compilation unit includes config.h, we currently compile half of
Nix with _FILE_OFFSET_BITS=64 and other half with _FILE_OFFSET_BITS
unset. This causes major havoc with the Settings class on e.g. 32-bit ARM,
where different compilation units disagree with the struct layout.

E.g.:

diff --git a/src/libstore/globals.cc b/src/libstore/globals.cc
@@ -166,6 +166,8 @@ void Settings::update()
     _get(useSubstitutes, "build-use-substitutes");
+    fprintf(stderr, "at Settings::update(): &useSubstitutes = %p\n", &nix::settings.useSubstitutes);
     _get(buildUsersGroup, "build-users-group");
diff --git a/src/libstore/remote-store.cc b/src/libstore/remote-store.cc
+++ b/src/libstore/remote-store.cc
@@ -138,6 +138,8 @@ void RemoteStore::initConnection(Connection & conn)
 void RemoteStore::setOptions(Connection & conn)
 {
+    fprintf(stderr, "at RemoteStore::setOptions(): &useSubstitutes = %p\n", &nix::settings.useSubstitutes);
     conn.to << wopSetOptions

Gave me:

at Settings::update(): &useSubstitutes = 0xb6e5c5cb
at RemoteStore::setOptions(): &useSubstitutes = 0xb6e5c5c7

That was not a fun one to debug!
2017-02-08 21:51:02 +02:00
..
primops Support Git repos in the Nix path 2016-04-29 21:07:47 +02:00
attr-path.cc Optimize small lists 2015-07-23 22:05:09 +02:00
attr-path.hh Work on Values instead of Exprs 2013-09-03 13:17:51 +00:00
attr-set.cc Optimize empty sets 2015-07-23 23:11:08 +02:00
attr-set.hh Bindings: Add a method for iterating in lexicographically sorted order 2017-01-26 20:40:33 +01:00
common-opts.cc Enable HTTP/2 support 2016-09-14 16:36:02 +02:00
common-opts.hh StoreAPI -> Store 2016-02-04 14:48:42 +01:00
eval-inline.hh isFunctor: Simplify 2015-10-08 13:22:11 +02:00
eval.cc Add support for passing structured data to builders 2017-01-26 20:40:33 +01:00
eval.hh Add support for passing structured data to builders 2017-01-26 20:40:33 +01:00
get-drvs.cc Bindings: Add a method for iterating in lexicographically sorted order 2017-01-26 20:40:33 +01:00
get-drvs.hh nix-env: respect meta.outputsToInstall 2016-02-23 14:19:14 +01:00
json-to-value.cc Include config.h implicitly with '-include config.h' in CFLAGS 2017-02-08 21:51:02 +02:00
json-to-value.hh Add builtin function ‘fromJSON’ 2014-07-04 13:34:15 +02:00
lexer.l Tweak error message 2016-12-06 17:18:40 +01:00
local.mk Make primop registration pluggable 2016-04-14 12:50:01 +02:00
names.cc replace own regex class with std::regex 2016-10-18 20:22:25 +02:00
names.hh replace own regex class with std::regex 2016-10-18 20:22:25 +02:00
nix-expr.pc.in Install some pkgconfig files 2014-09-18 12:00:40 +02:00
nixexpr.cc First hit at providing support for floats in the language. 2016-01-05 00:40:40 +01:00
nixexpr.hh Throw a specific error for incomplete parse errors. 2016-02-24 04:32:21 -06:00
parser.y printMsg(lvlError, ...) -> printError(...) etc. 2016-09-21 16:54:53 +02:00
primops.cc Add support for passing structured data to builders 2017-01-26 20:40:33 +01:00
primops.hh Make primop registration pluggable 2016-04-14 12:50:01 +02:00
symbol-table.hh Include config.h implicitly with '-include config.h' in CFLAGS 2017-02-08 21:51:02 +02:00
value-to-json.cc nix path-info: Add --json flag 2016-08-29 17:29:24 +02:00
value-to-json.hh nix path-info: Add --json flag 2016-08-29 17:29:24 +02:00
value-to-xml.cc First hit at providing support for floats in the language. 2016-01-05 00:40:40 +01:00
value-to-xml.hh Use "#pragma once" to prevent repeated header file inclusion 2012-07-18 14:59:03 -04:00
value.hh Include config.h implicitly with '-include config.h' in CFLAGS 2017-02-08 21:51:02 +02:00