Merge changes I4bffa766,If2561cd5 into main

* changes:
  add and fix -Wignored-qualifiers
  add and fix -Wdeprecated-copy

meson.build

@@ -405,6 +405,8 @@ add_project_arguments(
   '-Wimplicit-fallthrough',
   '-Werror=switch',
   '-Werror=switch-enum',
+  '-Wdeprecated-copy',
+  '-Wignored-qualifiers',
   # Enable assertions in libstdc++ by default. Harmless on libc++. Benchmarked
   # at ~1% overhead in `nix search`.
   #

src/libfetchers/tarball.cc

@@ -186,7 +186,7 @@ struct CurlInputScheme : InputScheme
     virtual const std::string inputType() const = 0;
     const std::set<std::string> transportUrlSchemes = {"file", "http", "https"};
 
-    const bool hasTarballExtension(std::string_view path) const
+    bool hasTarballExtension(std::string_view path) const
     {
         return path.ends_with(".zip") || path.ends_with(".tar")
             || path.ends_with(".tgz") || path.ends_with(".tar.gz")

src/libutil/fmt.hh

@@ -185,6 +185,8 @@ public:
 
     HintFmt(const HintFmt & hf) : fmt(hf.fmt) {}
 
+    HintFmt & operator=(HintFmt const & rhs) = default;
+
     std::string str() const
     {
         return fmt.str();

src/libutil/ref.hh

@@ -77,6 +77,8 @@ public:
         return ref<T2>((std::shared_ptr<T2>) p);
     }
 
+    ref<T> & operator=(ref<T> const & rhs) = default;
+
     bool operator == (const ref<T> & other) const
     {
         return p == other.p;