lix-project/lix-install-action
1
0
Fork 0
Code Issues 11 Pull requests Packages Projects Releases Wiki Activity

action: post-run-job: try clean daemon container, warn on failure #61

Merged
colemickens merged 2 commits from colemickens/ghes-docker-cleanup into main 2023-12-19 16:01:57 +00:00
Conversation 3 Commits 2 Files changed 4 +49 -3
colemickens commented 2023-12-11 16:00:04 +00:00 (Migrated from github.com)
Copy link
Description

This:

  • carries a tiny commit to add a typescript LSP to our flake, which was useful even for this small change
  • attempts to make cleaning up the docker daemon container aspiration
  • attempts to make any failures to clean such container, non-fatal to the workflow

I say attempts because I haven't managed to hit this soft-failure path at all with GHA. I've done maybe a dozen runs, each of which containing 2 NS runs, and I've only seen happy path so far.

However, given a careful review, I think this change is still an improvement and safe to merge and iterate on whenever we see this actually repro in the wild.

Checklist
  • Tested changes against a test repository (sort of, against this repo with dispathed workflows)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)
##### Description This: * carries a tiny commit to add a typescript LSP to our flake, which was useful even for this small change * attempts to make cleaning up the docker daemon container aspiration * attempts to make any failures to clean such container, non-fatal to the workflow I say attempts because I haven't managed to hit this soft-failure path at all with GHA. I've done maybe a dozen runs, each of which containing 2 NS runs, and I've only seen happy path so far. However, given a careful review, I think this change is still an improvement and safe to merge and iterate on whenever we see this actually repro in the wild. ##### Checklist - [ ] Tested changes against a test repository (sort of, against this repo with dispathed workflows) - [ ] Added or updated relevant documentation (leave unchecked if not applicable) - [ ] (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)
colemickens commented 2023-12-18 16:06:34 +00:00 (Migrated from github.com)
Copy link

Added another commit to use -f with pkill which is necessary for pkill to look at the arguments for kill consideration.

Added another commit to use `-f` with `pkill` which is necessary for `pkill` to look at the arguments for kill consideration.
grahamc commented 2023-12-18 16:15:06 +00:00 (Migrated from github.com)
Copy link

This lgtm but I can't give it a actual code review right now, just an idea review.

This lgtm but I can't give it a actual code review right now, just an idea review.
grahamc (Migrated from github.com) approved these changes 2023-12-19 16:01:52 +00:00
colemickens commented 2023-12-19 16:02:06 +00:00 (Migrated from github.com)
Copy link

🎊

:confetti_ball:
Sign in to join this conversation.
Reviewers
No reviewers
grahamc
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix-install-action#61
No description provided.
Delete branch "colemickens/ghes-docker-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?