lix-project/lix-install-action
1
0
Fork 0
Code Issues 11 Pull requests Packages Projects Releases Wiki Activity

KVM support out of the box, plus a refreshed README #56

Merged
grahamc merged 5 commits from kvm into main 2023-11-21 19:06:06 +00:00
Conversation 0 Commits 5 Files changed 5 +240 -15
grahamc commented 2023-11-21 17:21:30 +00:00 (Migrated from github.com)
Copy link
Description

Turns out GitHub Actions's hosted runners support KVM out of the box, as long as either:

  1. it is an open source project (this is an undocumented perk as far as I can tell)
  2. it is a paid-for, larger runner
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)
##### Description Turns out GitHub Actions's hosted runners support KVM out of the box, as long as either: 1. it is an open source project (this is an undocumented perk as far as I can tell) 2. it is a paid-for, larger runner ##### Checklist - [ ] Tested changes against a test repository - [ ] Added or updated relevant documentation (leave unchecked if not applicable) - [ ] (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)
flexiondotorg (Migrated from github.com) approved these changes 2023-11-21 17:32:05 +00:00
flexiondotorg (Migrated from github.com) left a comment
Copy link

Looks good to me 👍 Exactly what we discussed.

Looks good to me :+1: Exactly what we discussed.
Hoverbear (Migrated from github.com) reviewed 2023-11-21 17:46:54 +00:00
README.md
Hoverbear (Migrated from github.com) commented 2023-11-21 17:46:54 +00:00
Copy link
* If KVM is available, the installer sets up KVM so that Nix can use it ,and exports the `DETERMINATE_NIX_KVM` environment variable set to 1.
```suggestion * If KVM is available, the installer sets up KVM so that Nix can use it ,and exports the `DETERMINATE_NIX_KVM` environment variable set to 1. ```
Hoverbear (Migrated from github.com) reviewed 2023-11-21 17:48:25 +00:00
dist/index.js
@ -308,0 +354,4 @@
_actions_core__WEBPACK_IMPORTED_MODULE_0__.debug(trimmed);
}
},
},
Hoverbear (Migrated from github.com) commented 2023-11-21 17:48:25 +00:00
Copy link

Graham "Don't write bash" Christensen. 😏

Graham "Don't write bash" Christensen. 😏
Hoverbear (Migrated from github.com) approved these changes 2023-11-21 17:50:35 +00:00
Hoverbear (Migrated from github.com) left a comment
Copy link

Barring the README tweak this looks fine, I get why you had to call Bash. :)

Barring the README tweak this looks fine, I get why you had to call Bash. :)
grahamc (Migrated from github.com) reviewed 2023-11-21 18:45:05 +00:00
dist/index.js
@ -308,0 +354,4 @@
_actions_core__WEBPACK_IMPORTED_MODULE_0__.debug(trimmed);
}
},
},
grahamc (Migrated from github.com) commented 2023-11-21 18:45:05 +00:00
Copy link

🤡 I didn't want to 😭

🤡 I didn't want to 😭
lucperkins (Migrated from github.com) reviewed 2023-11-21 18:52:16 +00:00
README.md
lucperkins (Migrated from github.com) commented 2023-11-21 18:52:16 +00:00
Copy link
* ✅ **Accelerated KVM** on open source projects and larger runners. See [GitHub's announcement](https://github.blog/changelog/2023-02-23-hardware-accelerated-androidvirtualization-on-actions-windows-and-linux-larger-hosted-runners) for more info.
```suggestion * ✅ **Accelerated KVM** on open source projects and larger runners. See [GitHub's announcement](https://github.blog/changelog/2023-02-23-hardware-accelerated-androidvirtualization-on-actions-windows-and-linux-larger-hosted-runners) for more info. ```
grahamc (Migrated from github.com) reviewed 2023-11-21 19:00:00 +00:00
README.md
grahamc (Migrated from github.com) commented 2023-11-21 19:00:00 +00:00
Copy link
* ✅ **Accelerated KVM** on open source projects and larger runners. See [GitHub's announcement](https://github.blog/changelog/2023-02-23-hardware-accelerated-android-virtualization-on-actions-windows-and-linux-larger-hosted-runners/) for more info.
```suggestion * ✅ **Accelerated KVM** on open source projects and larger runners. See [GitHub's announcement](https://github.blog/changelog/2023-02-23-hardware-accelerated-android-virtualization-on-actions-windows-and-linux-larger-hosted-runners/) for more info. ```
Sign in to join this conversation.
Reviewers
No reviewers
flexiondotorg
Hoverbear
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix-install-action#56
No description provided.
Delete branch "kvm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?