lix-project/lix-install-action
1
0
Fork 0
Code Issues 11 Pull requests Packages Projects Releases Wiki Activity

main.ts: fixup logic to ensure only one installer url override is set #44

Merged
colemickens merged 1 commit from fixup-nix-url-check into main 2023-10-18 17:24:39 +00:00
Conversation 0 Commits 1 Files changed 1 +10 -5
colemickens commented 2023-10-18 14:39:11 +00:00 (Migrated from github.com)
Copy link
Description
  • the use of else if would have made the "counting" of the url modifiers useless, so switch them to ifs.
  • correspondingly, update the fallthrough else condition to set the URL if no modifiers were passed to override it
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)
##### Description * the use of `else if` would have made the "counting" of the url modifiers useless, so switch them to ifs. * correspondingly, update the fallthrough `else` condition to set the URL if no modifiers were passed to override it ##### Checklist - [x] Tested changes against a test repository - [ ] Added or updated relevant documentation (leave unchecked if not applicable) - [ ] (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)
Hoverbear (Migrated from github.com) approved these changes 2023-10-18 17:24:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Hoverbear
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix-install-action#44
No description provided.
Delete branch "fixup-nix-url-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?