Update to node20 #40

New issue

Closed

opened 2023-10-12 13:52:26 +00:00 by lovesegfault · 2 comments

lovesegfault commented 2023-10-12 13:52:26 +00:00 (Migrated from github.com)

Copy link

The action is still on node16, but by default configured runners on NixOS only come with node20, causing the action to fail.

It should probably be moved to node20, if there are no drawbacks?

DeterminateSystems/nix-installer-action@07ebb8d274/action.yml (L108-L111)

The action is still on `node16`, but by default configured runners on NixOS only come with `node20`, causing the action to fail. It should probably be moved to `node20`, if there are no drawbacks? https://github.com/DeterminateSystems/nix-installer-action/blob/07ebb8d2749aa2fac2baae7d1cfa011e4acfd8d1/action.yml#L108-L111

grahamc commented 2023-10-12 14:11:12 +00:00 (Migrated from github.com)

Copy link

I just moved it to node20 in #41. I don't think there is any reason to avoid the update and typescript didn't even recompile differently. Let's see what the tests do and find out!

I just moved it to node20 in #41. I don't think there is any reason to avoid the update and typescript didn't even recompile differently. Let's see what the tests do and find out!

❤️ 1

grahamc commented 2023-10-12 18:58:19 +00:00 (Migrated from github.com)

Copy link

Released in v6 :).

Released in v6 :).

🎉 1

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

detsys-ts-results

revert-76-general-cleanup

colemickens/debug

try-env-style-settings

test-extra-conf

v11

v10

v9

v8

v7

v6

v5

v4

v3

v2

v1

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lix-project/lix-install-action#40

No description provided.