lix-project/lix-install-action
1
0
Fork 0
Code Issues 11 Pull requests Packages Projects Releases Wiki Activity

Add start-daemon and init args #4

Merged
Hoverbear merged 6 commits from start-daemon-and-init into main 2023-02-07 15:23:59 +00:00
Conversation 1 Commits 6 Files changed 1 +67 -24
Hoverbear commented 2023-01-24 16:18:57 +00:00 (Migrated from github.com)
Copy link

Goes along with https://github.com/DeterminateSystems/nix-installer/pull/188

Goes along with https://github.com/DeterminateSystems/nix-installer/pull/188
Hoverbear commented 2023-01-30 22:15:19 +00:00 (Migrated from github.com)
Copy link

Planning to tag this after merge.

Planning to tag this after merge.
cole-h (Migrated from github.com) approved these changes 2023-01-30 22:36:53 +00:00
cole-h (Migrated from github.com) left a comment
Copy link

LGTM aside from these few comments.

LGTM aside from these few comments.
action.yml
cole-h (Migrated from github.com) commented 2023-01-30 22:33:27 +00:00
Copy link

Nit:

    description: "If the daemon should be started, requires `planner: linux-multi`"
Nit: ```suggestion description: "If the daemon should be started, requires `planner: linux-multi`" ```
cole-h (Migrated from github.com) commented 2023-01-30 22:35:31 +00:00
Copy link
    required: false
```suggestion required: false ```
action.yml
cole-h (Migrated from github.com) commented 2023-01-30 22:36:19 +00:00
Copy link

IMHO "conflicts" means there will be an error, but if my eyes (and brain) don't deceive me, it seems like the script will just choose which it encounters first. Maybe it should be "takes priority over ...." instead.

IMHO "conflicts" means there will be an error, but if my eyes (and brain) don't deceive me, it seems like the script will just choose which it encounters first. Maybe it should be "takes priority over ...." instead.
Hoverbear (Migrated from github.com) reviewed 2023-01-31 18:08:30 +00:00
action.yml
Hoverbear (Migrated from github.com) commented 2023-01-31 18:08:30 +00:00
Copy link

I made this an actual conflict with error. :)

I made this an actual conflict with error. :)
cole-h (Migrated from github.com) reviewed 2023-01-31 18:13:22 +00:00
action.yml
cole-h (Migrated from github.com) commented 2023-01-31 18:13:22 +00:00
Copy link

It seems like these also conflict with nix-installer-url, right? Since these are only reachable via the "else" branch of "if inputs.nix-installer-url".

It seems like these also conflict with nix-installer-url, right? Since these are only reachable via the "else" branch of "if inputs.nix-installer-url".
Hoverbear (Migrated from github.com) reviewed 2023-02-01 18:18:37 +00:00
action.yml
Hoverbear (Migrated from github.com) commented 2023-02-01 18:18:37 +00:00
Copy link

Oh, yes!

Oh, yes!
cole-h (Migrated from github.com) approved these changes 2023-02-01 18:22:55 +00:00
cole-h (Migrated from github.com) left a comment
Copy link

Looks fine now.

Looks fine now.
Sign in to join this conversation.
Reviewers
No reviewers
cole-h
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/lix-install-action#4
No description provided.
Delete branch "start-daemon-and-init"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?