lix-project/lix-install-action
1
0
Fork 0
Code Issues 11 Pull requests Packages Projects Releases Wiki Activity

Better messaging when we set GITHUB_PATH

Browse source
This commit is contained in:
Ana Hobden 2023-07-14 09:07:56 -07:00
parent bdec4311cf
commit d29c939172
3 changed files with 52 additions and 59 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
dist/index.js vendored
View file

@ -261,8 +261,11 @@ class NixInstallerAction {
return __awaiter(this, void 0, void 0, function* () {
// Interim versions of the `nix-installer` crate may have already manipulated `$GITHUB_PATH`, as root even! Accessing that will be an error.
try {
actions_core.addPath("/nix/var/nix/profiles/default/bin");
actions_core.addPath(`${process.env.HOME}/.nix-profile/bin`);
const nix_var_nix_profile_path = "/nix/var/nix/profiles/default/bin";
const home_nix_profile_path = `${process.env.HOME}/.nix-profile/bin`;
actions_core.addPath(nix_var_nix_profile_path);
actions_core.addPath(home_nix_profile_path);
actions_core.info(`Added \`${nix_var_nix_profile_path}\` and \`${home_nix_profile_path}\` to \`$GITHUB_PATH\``);
}
catch (error) {
actions_core.warning("Skipping setting $GITHUB_PATH in action, the `nix-installer` crate seems to have done this already. From `nix-installer` version 0.11.0 and up, this step is only done in the action. Prior to 0.11.0, this was done in the `nix-installer` binary.");
@ -382,43 +385,35 @@ function resolve_nix_installer_url(platform) {
const nix_installer_revision = action_input_string_or_null("nix-installer-revision");
const nix_installer_tag = action_input_string_or_null("nix-installer-tag");
const nix_installer_url = action_input_string_or_null("nix-installer-url");
let resolved_nix_installer_url = null;
let num_set = 0;
if (nix_installer_branch !== null) {
num_set += 1;
resolved_nix_installer_url = new URL(`https://install.determinate.systems/nix/branch/${nix_installer_branch}/nix-installer-${platform}?ci=github`);
}
if (nix_installer_pr !== null) {
else if (nix_installer_pr !== null) {
num_set += 1;
resolved_nix_installer_url = new URL(`https://install.determinate.systems/nix/pr/${nix_installer_pr}/nix-installer-${platform}?ci=github`);
}
if (nix_installer_revision !== null) {
else if (nix_installer_revision !== null) {
num_set += 1;
resolved_nix_installer_url = new URL(`https://install.determinate.systems/nix/rev/${nix_installer_revision}/nix-installer-${platform}?ci=github`);
}
if (nix_installer_tag !== null) {
else if (nix_installer_tag !== null) {
num_set += 1;
resolved_nix_installer_url = new URL(`https://install.determinate.systems/nix/tag/${nix_installer_tag}/nix-installer-${platform}?ci=github`);
}
if (nix_installer_url !== null) {
else if (nix_installer_url !== null) {
num_set += 1;
resolved_nix_installer_url = new URL(nix_installer_url);
}
else {
resolved_nix_installer_url = new URL(`https://install.determinate.systems/nix/nix-installer-${platform}?ci=github`);
}
if (num_set > 1) {
throw new Error(`The following options are mututally exclusive, but ${num_set} were set: \`nix_installer_branch\`, \`nix_installer_pr\`, \`nix_installer_revision\`, \`nix_installer_tag\`, and \`nix_installer_url\``);
}
if (nix_installer_branch !== null) {
return new URL(`https://install.determinate.systems/nix/branch/${nix_installer_branch}/nix-installer-${platform}?ci=github`);
}
else if (nix_installer_pr !== null) {
return new URL(`https://install.determinate.systems/nix/pr/${nix_installer_pr}/nix-installer-${platform}?ci=github`);
}
else if (nix_installer_revision !== null) {
return new URL(`https://install.determinate.systems/nix/rev/${nix_installer_revision}/nix-installer-${platform}?ci=github`);
}
else if (nix_installer_tag !== null) {
return new URL(`https://install.determinate.systems/nix/tag/${nix_installer_tag}/nix-installer-${platform}?ci=github`);
}
else if (nix_installer_url !== null) {
return new URL(nix_installer_url);
}
else {
return new URL(`https://install.determinate.systems/nix/nix-installer-${platform}?ci=github`);
}
return resolved_nix_installer_url;
}
function action_input_string_or_null(name) {
const value = actions_core.getInput(name);

2
dist/index.js.map vendored
View file

File diff suppressed because one or more lines are too long

66
src/main.ts
View file

@ -299,8 +299,13 @@ class NixInstallerAction {
async set_github_path(): Promise<void> {
// Interim versions of the `nix-installer` crate may have already manipulated `$GITHUB_PATH`, as root even! Accessing that will be an error.
try {
actions_core.addPath("/nix/var/nix/profiles/default/bin");
actions_core.addPath(`${process.env.HOME}/.nix-profile/bin`);
const nix_var_nix_profile_path = "/nix/var/nix/profiles/default/bin";
const home_nix_profile_path = `${process.env.HOME}/.nix-profile/bin`;
actions_core.addPath(nix_var_nix_profile_path);
actions_core.addPath(home_nix_profile_path);
actions_core.info(
`Added \`${nix_var_nix_profile_path}\` and \`${home_nix_profile_path}\` to \`$GITHUB_PATH\``,
);
} catch (error) {
actions_core.warning(
"Skipping setting $GITHUB_PATH in action, the `nix-installer` crate seems to have done this already. From `nix-installer` version 0.11.0 and up, this step is only done in the action. Prior to 0.11.0, this was done in the `nix-installer` binary.",
@ -463,51 +468,44 @@ function resolve_nix_installer_url(platform: string): URL {
const nix_installer_tag = action_input_string_or_null("nix-installer-tag");
const nix_installer_url = action_input_string_or_null("nix-installer-url");
let resolved_nix_installer_url = null;
let num_set = 0;
if (nix_installer_branch !== null) {
num_set += 1;
}
if (nix_installer_pr !== null) {
resolved_nix_installer_url = new URL(
`https://install.determinate.systems/nix/branch/${nix_installer_branch}/nix-installer-${platform}?ci=github`,
);
} else if (nix_installer_pr !== null) {
num_set += 1;
}
if (nix_installer_revision !== null) {
resolved_nix_installer_url = new URL(
`https://install.determinate.systems/nix/pr/${nix_installer_pr}/nix-installer-${platform}?ci=github`,
);
} else if (nix_installer_revision !== null) {
num_set += 1;
}
if (nix_installer_tag !== null) {
resolved_nix_installer_url = new URL(
`https://install.determinate.systems/nix/rev/${nix_installer_revision}/nix-installer-${platform}?ci=github`,
);
} else if (nix_installer_tag !== null) {
num_set += 1;
}
if (nix_installer_url !== null) {
resolved_nix_installer_url = new URL(
`https://install.determinate.systems/nix/tag/${nix_installer_tag}/nix-installer-${platform}?ci=github`,
);
} else if (nix_installer_url !== null) {
num_set += 1;
resolved_nix_installer_url = new URL(nix_installer_url);
} else {
resolved_nix_installer_url = new URL(
`https://install.determinate.systems/nix/nix-installer-${platform}?ci=github`,
);
}
if (num_set > 1) {
throw new Error(
`The following options are mututally exclusive, but ${num_set} were set: \`nix_installer_branch\`, \`nix_installer_pr\`, \`nix_installer_revision\`, \`nix_installer_tag\`, and \`nix_installer_url\``,
);
}
if (nix_installer_branch !== null) {
return new URL(
`https://install.determinate.systems/nix/branch/${nix_installer_branch}/nix-installer-${platform}?ci=github`,
);
} else if (nix_installer_pr !== null) {
return new URL(
`https://install.determinate.systems/nix/pr/${nix_installer_pr}/nix-installer-${platform}?ci=github`,
);
} else if (nix_installer_revision !== null) {
return new URL(
`https://install.determinate.systems/nix/rev/${nix_installer_revision}/nix-installer-${platform}?ci=github`,
);
} else if (nix_installer_tag !== null) {
return new URL(
`https://install.determinate.systems/nix/tag/${nix_installer_tag}/nix-installer-${platform}?ci=github`,
);
} else if (nix_installer_url !== null) {
return new URL(nix_installer_url);
} else {
return new URL(
`https://install.determinate.systems/nix/nix-installer-${platform}?ci=github`,
);
}
return resolved_nix_installer_url;
}
function action_input_string_or_null(name: string): string | null {