lix main changes break hydra [2025-03-23] #32

New issue

Closed

opened 2025-03-24 00:05:09 +00:00 by benaryorg · 0 comments

benaryorg commented

2025-03-24 00:05:09 +00:00

Contributor

One of the recent changes in lix main have caused build failures in hydra due to changes in JSON handling causing, among other errors, this:

../src/hydra-queue-runner/hydra-queue-runner.cc:605:5: error: reference to 'json' is ambiguous
  605 |     json statusJson = {
      |     ^
../src/hydra-queue-runner/hydra-queue-runner.cc:27:17: note: candidate found by name lookup is 'json'
   27 | using nlohmann::json;
      |                 ^
/nix/store/q81nvxvp0psdjrpyjly6pxj23cbz79r8-lix-2.93.0-dev-dev/include/lix/libutil/json-fwd.hh:8:11: note: candidate found by name lookup is 'nix::json'
    8 | namespace json {
      |           ^

Feel free to tell me to not open issues for this right away.
I kinda have CI for this now so I notice breaking changes pretty much instantly, but I get that the open issues can be annoying if someone's already working on it.

One of the [recent changes in lix main](https://hydra.cloud.bsocat.net/api/scmdiff?rev2=56df5ba164a006902a1092ffcaaf42bb963fcc78&branch=&type=git&uri=https%3A%2F%2Fgit.shell.bsocat.net%2Flix&rev1=f7d1a6ba8b97a83c4d7a7dfe642ffbd00d6f4bcc) have caused [build failures in hydra](https://hydra.cloud.bsocat.net/build/289075/nixlog/14) due to changes in JSON handling causing, among other errors, this: ```text ../src/hydra-queue-runner/hydra-queue-runner.cc:605:5: error: reference to 'json' is ambiguous 605 | json statusJson = { | ^ ../src/hydra-queue-runner/hydra-queue-runner.cc:27:17: note: candidate found by name lookup is 'json' 27 | using nlohmann::json; | ^ /nix/store/q81nvxvp0psdjrpyjly6pxj23cbz79r8-lix-2.93.0-dev-dev/include/lix/libutil/json-fwd.hh:8:11: note: candidate found by name lookup is 'nix::json' 8 | namespace json { | ^ ``` Feel free to tell me to not open issues for this right away. I kinda have CI for this now so I notice breaking changes pretty much instantly, but I get that the open issues can be annoying if someone's already working on it.