diff --git a/src/lib/Hydra/Controller/JobsetEval.pm b/src/lib/Hydra/Controller/JobsetEval.pm index 17b14ae1..d1aef2bd 100644 --- a/src/lib/Hydra/Controller/JobsetEval.pm +++ b/src/lib/Hydra/Controller/JobsetEval.pm @@ -64,18 +64,9 @@ sub view_GET { $c->stash->{otherEval} = $eval2 if defined $eval2; - sub cmpBuilds { - my ($left, $right) = @_; - return $left->get_column('job') cmp $right->get_column('job') - || $left->get_column('system') cmp $right->get_column('system') - } - my @builds = $eval->builds->search($filter, { columns => [@buildListColumns] }); my @builds2 = defined $eval2 ? $eval2->builds->search($filter, { columns => [@buildListColumns] }) : (); - @builds = sort { cmpBuilds($a, $b) } @builds; - @builds2 = sort { cmpBuilds($a, $b) } @builds2; - buildDiff(@builds, @builds2); $c->stash->{full} = ($c->req->params->{full} || "0") eq "1"; diff --git a/src/lib/Hydra/Helper/BuildDiff.pm b/src/lib/Hydra/Helper/BuildDiff.pm index fb6e6543..08308a6d 100644 --- a/src/lib/Hydra/Helper/BuildDiff.pm +++ b/src/lib/Hydra/Helper/BuildDiff.pm @@ -15,6 +15,15 @@ our @EXPORT = qw( use Data::Dumper; +sub cmpBuilds { + my ($left, $right) = @_; + return $left->get_column('job') cmp $right->get_column('job') + || $left->get_column('system') cmp $right->get_column('system') +} + + # $builds = sort { cmpBuilds($a, $b) } $builds; + # $builds2 = sort { cmpBuilds($a, $b) } $builds2; + sub buildDiff { my ($builds, $builds2) = @_;