GitlabStatus: $build -> $topbuild, $b -> $build (perlcritic)

This commit is contained in:
Graham Christensen 2021-08-20 21:40:25 -04:00
parent b4a19fd3c8
commit bcf37ab705

View file

@ -37,25 +37,25 @@ sub toGitlabState {
}
sub common {
my ($self, $build, $dependents, $status) = @_;
my ($self, $topbuild, $dependents, $status) = @_;
my $baseurl = $self->{config}->{'base_uri'} || "http://localhost:3000";
# Find matching configs
foreach my $b ($build, @{$dependents}) {
my $jobName = showJobName $b;
my $evals = $build->jobsetevals;
foreach my $build ($topbuild, @{$dependents}) {
my $jobName = showJobName $build;
my $evals = $topbuild->jobsetevals;
my $ua = LWP::UserAgent->new();
# Don't send out "pending/running" status updates if the build is already finished
next if $status < 2 && $b->finished == 1;
next if $status < 2 && $build->finished == 1;
my $state = toGitlabState($status, $b->buildstatus);
my $state = toGitlabState($status, $build->buildstatus);
my $body = encode_json(
{
state => $state,
target_url => "$baseurl/build/" . $b->id,
description => "Hydra build #" . $b->id . " of $jobName",
name => "Hydra " . $b->get_column('job'),
target_url => "$baseurl/build/" . $build->id,
description => "Hydra build #" . $build->id . " of $jobName",
name => "Hydra " . $build->get_column('job'),
});
while (my $eval = $evals->next) {
my $gitlabstatusInput = $eval->jobsetevalinputs->find({ name => "gitlab_status_repo" });