From 73694087a088ed4481b4ab268a03351b1bcaac3c Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Sat, 21 Mar 2020 21:08:33 +0100 Subject: [PATCH] Use the stopsign as icon for timeouts and exceeded log-limits When I browse failed builds in a jobset-eval on Hydra, I regularly mistake actual build-failures with temporary issues like timeouts (that probably disappear at the next eval). To prevent this kind of issue, I figured that using the stopsign-svg for builds with timeouts or exceeded log-limits is a reasonable choice for the following reasons: * A user can now distinguish between actual build-errors (like compilation-failures or oversized outputs) and (usually) temporary issues (like a bloated log or a timeout). * The stopsign is also used for aborted jobs that are shown in a different tab and can't be confused with timeouts for that reason. --- src/root/common.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/root/common.tt b/src/root/common.tt index ed59da67..83b1c736 100644 --- a/src/root/common.tt +++ b/src/root/common.tt @@ -229,9 +229,9 @@ BLOCK renderBuildStatusIcon; [% ELSIF buildstatus == 6 %] Failed with output [% ELSIF buildstatus == 7 %] - Timed out + Timed out [% ELSIF buildstatus == 10 %] - Log limit exceeded + Log limit exceeded [% ELSIF buildstatus == 11 %] Output size limit exceeded [% ELSIF buildstatus == 12 %]