lix-project/hydra
4
0
Fork 6
Code Issues 2 Pull requests Packages Projects Releases Wiki Activity

perlcritic: make all open() calls three-argument

Browse source 
Two-argument calls end up parsing the second argument to guess what
should happen, three-arg parses ... less?
This commit is contained in:
Graham Christensen 2021-10-19 22:37:17 -04:00
parent 43c056bb7b
commit 7095d00608
5 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/lib/Hydra/Helper/Nix.pm
View file

@ -141,7 +141,7 @@ sub registerRoot {
my ($path) = @_;
my $link = gcRootFor $path;
return if -e $link;
open my $root, ">$link" or die "cannot create GC root `$link' to `$path'";
open(my $root, ">", $link) or die "cannot create GC root `$link' to `$path'";
close $root;
}
@ -342,7 +342,7 @@ sub getMachines {
for my $machinesFile (@machinesFiles) {
next unless -e $machinesFile;
open my $conf, "<$machinesFile" or die;
open(my $conf, "<", $machinesFile) or die;
while (my $line = <$conf>) {
chomp;
s/\#.*$//g;

2
src/lib/Hydra/View/NixClosure.pm
View file

@ -14,7 +14,7 @@ sub process {
my $fh = IO::Handle->new();
open $fh, "nix-store --export `nix-store -qR @storePaths` | gzip |";
open($fh, "-|", "nix-store --export `nix-store -qR @storePaths` | gzip");
$c->response->body($fh);

8
src/lib/Hydra/View/NixLog.pm
View file

@ -17,13 +17,13 @@ sub process {
my $tail = int($c->stash->{tail} // "0");
if ($logPath =~ /\.bz2$/) {
my $doTail = $tail ? " tail -n '$tail' |" : "";
open $fh, "bzip2 -dc < '$logPath' | $doTail" or die;
my $doTail = $tail ? "| tail -n '$tail'" : "";
open($fh, "-|", "bzip2 -dc < '$logPath' $doTail") or die;
} else {
if ($tail) {
open $fh, "tail -n '$tail' '$logPath' |" or die;
open($fh, "-|", "tail -n '$tail' '$logPath'") or die;
} else {
open $fh, "<$logPath" or die;
open($fh, "<", $logPath) or die;
}
}
binmode($fh);

2
src/lib/Hydra/View/NixNAR.pm
View file

@ -16,7 +16,7 @@ sub process {
my $fh = IO::Handle->new();
open $fh, "nix-store --dump '$storePath' | pixz -0 $pParam |";
open($fh, "-|", "nix-store --dump '$storePath' | pixz -0 $pParam");
setCacheHeaders($c, 365 * 24 * 60 * 60);

2
t/plugins/gitea.t
View file

@ -60,7 +60,7 @@ if (!defined($pid = fork())) {
kill('INT', $pid);
}
open my $fh, $filename or die ("Can't open(): $!\n");
open(my $fh, "<", $filename) or die ("Can't open(): $!\n");
my $i = 0;
my $uri = <$fh>;
my $data = <$fh>;