lix-project/hydra
3
0
Fork 6
Code Issues 2 Pull requests 1 Packages Projects Releases Wiki Activity

hydra-eval-jobs: Use function argument default values

Browse source
This commit is contained in:
Eelco Dolstra 2013-03-29 01:14:24 +01:00
parent d734b435fa
commit 61405ec58a
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/c/hydra-eval-jobs.cc
View file

@ -52,12 +52,16 @@ static void tryJobAlts(EvalState & state, XMLWriter & doc,
AutoArgs::const_iterator a = argsLeft.find(cur->name); AutoArgs::const_iterator a = argsLeft.find(cur->name);
if (a == argsLeft.end())
throw TypeError(format("job `%1%' requires an argument named `%2%'")
% attrPath % cur->name);
Formals::Formals_::iterator next = cur; ++next; Formals::Formals_::iterator next = cur; ++next;
if (a == argsLeft.end()) {
if (!cur->def)
throw TypeError(format("job `%1%' requires an argument named `%2%'")
% attrPath % cur->name);
tryJobAlts(state, doc, argsUsed, argsLeft, attrPath, fun, next, last, actualArgs);
return;
}
int n = 0; int n = 0;
foreach (ValueList::const_iterator, i, a->second) { foreach (ValueList::const_iterator, i, a->second) {
Bindings actualArgs2(actualArgs); // !!! inefficient Bindings actualArgs2(actualArgs); // !!! inefficient