lix-project/hydra
3
0
Fork 6
Code Issues 2 Pull requests 1 Packages Projects Releases Wiki Activity

jobset view: jump back to the proper tab when displaying all failed jobsets

Browse source 
When I press "n builds omitted" I get back to the first tab of a jobset.
This is extremely counter-intuitive, instead this notice should link to
the currently opened tab.
This commit is contained in:
Maximilian Bosch 2018-07-15 17:19:03 +02:00
parent c2e2b42877
commit 37d35ac51e
No known key found for this signature in database
GPG key ID: 091DBF4D1FC46B8E
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/root/jobset-eval.tt
View file

@ -96,7 +96,7 @@ c.uri_for(c.controller('JobsetEval').action_for('view'),
[% INCLUDE renderBuildListBody builds=builds.slice(0, (size > max ? max : size) - 1) [% INCLUDE renderBuildListBody builds=builds.slice(0, (size > max ? max : size) - 1)
hideProjectName=1 hideJobsetName=1 busy=0 %] hideProjectName=1 hideJobsetName=1 busy=0 %]
[% IF size > max; params = c.req.params; params.full = 1 %] [% IF size > max; params = c.req.params; params.full = 1 %]
<tr><td class="centered" colspan="6"><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id], params) %]"><em>([% size - max %] more builds omitted)</em></a></td></tr> <tr><td class="centered" colspan="6"><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id], params) %][% tabname %]"><em>([% size - max %] more builds omitted)</em></a></td></tr>
[% END %] [% END %]
[% INCLUDE renderBuildListFooter %] [% INCLUDE renderBuildListFooter %]
[% END %] [% END %]
@ -104,19 +104,19 @@ c.uri_for(c.controller('JobsetEval').action_for('view'),
<div class="tab-content"> <div class="tab-content">
<div id="tabs-aborted" class="tab-pane"> <div id="tabs-aborted" class="tab-pane">
[% INCLUDE renderSome builds=aborted %] [% INCLUDE renderSome builds=aborted tabname="#tabs-aborted" %]
</div> </div>
<div id="tabs-now-fail" class="tab-pane"> <div id="tabs-now-fail" class="tab-pane">
[% INCLUDE renderSome builds=nowFail %] [% INCLUDE renderSome builds=nowFail tabname="#tabs-now-fail" %]
</div> </div>
<div id="tabs-now-succeed" class="tab-pane"> <div id="tabs-now-succeed" class="tab-pane">
[% INCLUDE renderSome builds=nowSucceed %] [% INCLUDE renderSome builds=nowSucceed tabname="#tabs-now-succeed" %]
</div> </div>
<div id="tabs-new" class="tab-pane"> <div id="tabs-new" class="tab-pane">
[% INCLUDE renderSome builds=new %] [% INCLUDE renderSome builds=new tabname="#tabs-new" %]
</div> </div>
<div id="tabs-removed" class="tab-pane"> <div id="tabs-removed" class="tab-pane">
@ -133,22 +133,22 @@ c.uri_for(c.controller('JobsetEval').action_for('view'),
</tr> </tr>
[% END %] [% END %]
[% IF size > max; params = c.req.params; params.full = 1 %] [% IF size > max; params = c.req.params; params.full = 1 %]
<tr><td class="centered" colspan="2"><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id], params) %]"><em>([% size - max %] more jobs omitted)</em></a></td></tr> <tr><td class="centered" colspan="2"><a href="[% c.uri_for(c.controller('JobsetEval').action_for('view'), [eval.id], params) %]#tabs-removed"><em>([% size - max %] more jobs omitted)</em></a></td></tr>
[% END %] [% END %]
</tbody> </tbody>
</table> </table>
</div> </div>
<div id="tabs-still-fail" class="tab-pane"> <div id="tabs-still-fail" class="tab-pane">
[% INCLUDE renderSome builds=stillFail %] [% INCLUDE renderSome builds=stillFail tabname="#tabs-still-fail" %]
</div> </div>
<div id="tabs-still-succeed" class="tab-pane"> <div id="tabs-still-succeed" class="tab-pane">
[% INCLUDE renderSome builds=stillSucceed %] [% INCLUDE renderSome builds=stillSucceed tabname="#tabs-still-succeed" %]
</div> </div>
<div id="tabs-unfinished" class="tab-pane"> <div id="tabs-unfinished" class="tab-pane">
[% INCLUDE renderSome builds=unfinished %] [% INCLUDE renderSome builds=unfinished tabname="#tabs-unfinished" %]
</div> </div>
<div id="tabs-inputs" class="tab-pane"> <div id="tabs-inputs" class="tab-pane">