From 259d163ec910755f7e7861024736e347880dc871 Mon Sep 17 00:00:00 2001 From: Rob Vermaas Date: Fri, 10 Jun 2011 07:36:30 +0000 Subject: [PATCH] clean up build page for build that failed with result --- src/lib/Hydra/Controller/Build.pm | 2 +- src/root/build.tt | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/Hydra/Controller/Build.pm b/src/lib/Hydra/Controller/Build.pm index 3532d9ef..9efdc7d2 100644 --- a/src/lib/Hydra/Controller/Build.pm +++ b/src/lib/Hydra/Controller/Build.pm @@ -54,7 +54,7 @@ sub view_build : Chained('build') PathPart('') Args(0) { (my $lastBuildStep) = $build->buildsteps->search({},{order_by => "stepnr DESC", rows => 1}); my $path = defined $lastBuildStep ? $lastBuildStep->logfile : "" ; - if (defined $build->resultInfo && $build->resultInfo->buildstatus == 1 && !($path eq "") && -f $lastBuildStep->logfile) { + if (defined $build->resultInfo && ($build->resultInfo->buildstatus == 1 || $build->resultInfo->buildstatus == 6) && !($path eq "") && -f $lastBuildStep->logfile) { $c->stash->{logtext} = `tail -n 50 $path`; } diff --git a/src/root/build.tt b/src/root/build.tt index d9a7297c..82920c0b 100644 --- a/src/root/build.tt +++ b/src/root/build.tt @@ -180,7 +180,7 @@ [% END %] [% IF build.finished %] - [% IF build.buildsteps && build.resultInfo.buildstatus != 0 %] + [% IF build.buildsteps && build.resultInfo.buildstatus != 0 && build.resultInfo.buildstatus != 6 %] [% INCLUDE renderBuildSteps type="Failed" %] [% END %] @@ -190,9 +190,9 @@
- - [% IF prevSuccessfulBuild && firstBrokenBuild && firstBrokenBuild.id != build.id %][% END %] - + + [% IF prevSuccessfulBuild && firstBrokenBuild && firstBrokenBuild.id != build.id %][% END %] +
Last successful buildFirst broken buildThis buildLast successful build [% INCLUDE renderDateTime timestamp = prevSuccessfulBuild.timestamp %]First broken build [% INCLUDE renderDateTime timestamp = firstBrokenBuild.timestamp %]This build [% INCLUDE renderDateTime timestamp = build.timestamp %]
[% INCLUDE renderBuildStatusIcon build=prevSuccessfulBuild size=32 %] [% INCLUDE renderFullBuildLink build=prevSuccessfulBuild %]