lix-project/buildbot-nix
15
0
Fork 0
Code Issues 13 Pull requests 7 Packages Projects Releases Wiki Activity

feat: Report evaluation errors and fail the damn build #29

Open
jade wants to merge 1 commit from jade/report-eval-errors into forkos
pull from: jade/report-eval-errors
merge into: lix-project:forkos
Conversation 0 Commits 1 Files changed 1 +13 -1
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
buildbot_nix/__init__.py
View file

@ -404,6 +404,7 @@ class NixEvalCommand(buildstep.ShellMixin, steps.BuildStep):
if result == util.SUCCESS: if result == util.SUCCESS:
# create a ShellCommand for each stage and add them to the build # create a ShellCommand for each stage and add them to the build
jobs = [] jobs = []
eval_errors: list[tuple[str, str]] = []
for line in self.observer.getStdout().split("\n"): for line in self.observer.getStdout().split("\n"):
if line != "": if line != "":
@ -415,14 +416,25 @@ class NixEvalCommand(buildstep.ShellMixin, steps.BuildStep):
jobs.append(job) jobs.append(job)
filtered_jobs = [] filtered_jobs = []
for job in jobs: for job in jobs:
if err := job.get("error"):
eval_errors.append((job.get('attr'), err))
system = job.get("system") system = job.get("system")
if not system or system in self.supported_systems: # report eval errors if not system or system in self.supported_systems:
filtered_jobs.append(job) filtered_jobs.append(job)
# Filter out failed evaluations # Filter out failed evaluations
succeeded_jobs = [job for job in filtered_jobs if job.get('error') is None] succeeded_jobs = [job for job in filtered_jobs if job.get('error') is None]
drv_show_log: StreamLog = yield self.getLog("stdio") drv_show_log: StreamLog = yield self.getLog("stdio")
if eval_errors:
msg = "Failing job due to evaluation errors!\n"
msg += "\n".join(
f"- {attr}: {failure}" for (attr, failure) in eval_errors)
drv_show_log.addStdout(msg)
raise BuildbotNixError("Evaluation error in attributes: " + ", ".join(attr for (attr, _) in eval_errors))
all_deps = dict() all_deps = dict()
def closure_of(key, deps): def closure_of(key, deps):