lix-project/buildbot-nix
15
0
Fork 0
Code Issues 9 Pull requests 4 Packages Projects Releases Wiki Activity

chore(*): refactor the whole code #8

Merged
raito merged 24 commits from refactor into main 2024-10-05 18:31:28 +00:00
Conversation 3 Commits 24 Files changed 8 +314 -535
raito commented 2024-05-06 16:29:44 +00:00
Owner
Copy link

It is long due to move past the nice prototype, I will be trying to refactor the code, split it.

On my todolist, I have:

  • cleanup the GerritConfigurator options in the nix module and expose them
  • static configuration of projects on Gerrit
    - [ ] autodiscovery of projects on Gerrit dynamically moved to a next PR
  • make it clear what is the entrypoint accepted: .hydraJobs from what I understand
    - [ ] split up the super large __init__.py into multiple logical components moved to a next PR

Tested on buildbot.forkos.org.

It is long due to move past the nice prototype, I will be trying to refactor the code, split it. On my todolist, I have: - [x] cleanup the GerritConfigurator options in the nix module and expose them - [x] static configuration of projects on Gerrit ~~- [ ] autodiscovery of projects on Gerrit dynamically~~ moved to a next PR - [x] make it clear what is the entrypoint accepted: `.hydraJobs` from what I understand ~~- [ ] split up the super large `__init__.py` into multiple logical components~~ moved to a next PR Tested on buildbot.forkos.org.
raito added 4 commits 2024-05-06 16:29:49 +00:00 
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Instead of just commenting them out.

Signed-off-by: Raito Bezarius <raito@lix.systems>
raito changed title from chore(*): refactor the whole code to WIP: chore(*): refactor the whole code 2024-05-06 16:40:08 +00:00
raito added 1 commit 2024-05-06 16:40:58 +00:00 
Signed-off-by: Raito Bezarius <raito@lix.systems>
raito added 3 commits 2024-05-06 17:39:52 +00:00 
It was relying on GitHub stuff which we don't have and is not an option
we want to support.

If we wanted to do it, we would rather use S3 directly.

Signed-off-by: Raito Bezarius <raito@lix.systems>
Previously, we needed to hardcode the URL for private SSH keys,
this is cleaned up and we can iterate over each project for its
configuration.

Configuration is at deployment time.

Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
raito added 7 commits 2024-05-06 19:04:15 +00:00 
This makes it easier to make it configurable, this is step 1.

Signed-off-by: Raito Bezarius <raito@lix.systems>
Just iterate over all project names.

Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
Signed-off-by: Raito Bezarius <raito@lix.systems>
raito added 2 commits 2024-07-17 14:26:10 +00:00 
Worked around in our original deployment, here's a nicer way to set it.

Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
So that it's possible to plug another OAuth2 instance.

Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
raito force-pushed refactor from 13e4d080c3 to 75ebe61eb1 2024-07-17 14:33:21 +00:00 Compare
raito force-pushed refactor from 75ebe61eb1 to 1c841ebe2e 2024-07-17 14:37:52 +00:00 Compare
raito force-pushed refactor from 1c841ebe2e to 271935016a 2024-07-17 14:44:28 +00:00 Compare
raito force-pushed refactor from 271935016a to 4e5f0cb44b 2024-07-17 14:46:34 +00:00 Compare
raito added 1 commit 2024-07-17 14:49:17 +00:00 
Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
raito force-pushed refactor from 1077725153 to a473100d29 2024-07-17 14:52:08 +00:00 Compare
raito force-pushed refactor from a473100d29 to 1864839e20 2024-07-17 14:54:46 +00:00 Compare
raito force-pushed refactor from 1864839e20 to 8a1b11f8b1 2024-07-17 14:56:38 +00:00 Compare
raito added 1 commit 2024-07-17 15:20:23 +00:00 
Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
raito force-pushed refactor from 4a85b5d56b to 3821a116f5 2024-07-17 15:22:47 +00:00 Compare
raito added 1 commit 2024-07-17 15:24:37 +00:00 
Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
raito force-pushed refactor from c6e6b222ad to 8286c1028b 2024-07-17 15:26:05 +00:00 Compare
raito added 3 commits 2024-07-18 10:13:00 +00:00 
Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
raito force-pushed refactor from 6a6c293baf to 4ad5459da8 2024-07-18 10:15:53 +00:00 Compare
raito added 1 commit 2024-07-19 13:48:21 +00:00 
Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
raito added 1 commit 2024-07-19 13:55:06 +00:00 
Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
raito force-pushed refactor from bb3d863feb to c49e591ae5 2024-07-19 13:59:53 +00:00 Compare
raito force-pushed refactor from c49e591ae5 to 54bba654d4 2024-07-19 17:24:51 +00:00 Compare
raito changed title from WIP: chore(*): refactor the whole code to chore(*): refactor the whole code 2024-07-19 17:24:53 +00:00
raito commented 2024-07-19 17:25:09 +00:00
Author
Owner
Copy link

This is good enough for a merge, IMHO, @puck, can I ask you for a review?

This is good enough for a merge, IMHO, @puck, can I ask you for a review?
jade force-pushed refactor from 54bba654d4 to 2deaf9535f 2024-10-04 21:08:49 +00:00 Compare
jade commented 2024-10-04 21:09:03 +00:00
Owner
Copy link

I have rebased this. It can be merged with your signoff @raito.

I have rebased this. It can be merged with your signoff @raito.
jade force-pushed refactor from 2deaf9535f to 22a58ce038 2024-10-04 21:13:19 +00:00 Compare
raito merged commit 48828cb33f into main 2024-10-05 18:31:28 +00:00
raito deleted branch refactor 2024-10-05 18:31:29 +00:00
raito commented 2024-10-05 18:31:42 +00:00
Author
Owner
Copy link

It's now time to get the non-flakes PR as well.

It's now time to get the non-flakes PR as well.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/buildbot-nix#8
No description provided.
Delete branch "refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?