lix-project/buildbot-nix
15
0
Fork 0
Code Issues 9 Pull requests 3 Packages Projects Releases Wiki Activity

Operation Buildborg #20

New issue
Open
opened 2024-08-31 11:15:21 +00:00 by k900 · 2 comments
k900 commented 2024-08-31 11:15:21 +00:00
Member
Copy link

aka building ofborg on top of buildbot

Core ofborg features we need in rough order of complexity:

  • eval checks
    • should be made part of the normal buildbot eval (release-checks?)
  • rebuild count reports
    • special buildbot job that does two evals and runs a diff
    • refactor service to post results to gerrit
  • testing the affected packages
    • can we somehow use buildbot's change tracking for this? need investigating
  • magic ofborg build/eval/test commands
    • add a ForceScheduler for starters, then we can maybe do a webhook to start builds from gerrit commands
  • pinging maintainers
    • oof
aka building ofborg on top of buildbot Core ofborg features we need in rough order of complexity: - eval checks - should be made part of the normal buildbot eval (release-checks?) - rebuild count reports - special buildbot job that does two evals and runs a diff - refactor service to post results to gerrit - testing the affected packages - can we somehow use buildbot's change tracking for this? need investigating - magic ofborg build/eval/test commands - add a ForceScheduler for starters, then we can maybe do a webhook to start builds from gerrit commands - pinging maintainers - oof
jade commented 2024-09-02 00:31:08 +00:00
Owner
Copy link

Pinging maintainers should possibly be part of a separate tagging bot tbh, but I can also see wanting to just shove it in buildbot to use buildbot to deal with the gerrit API bits.

It looks like Google has a thingy here that has a web plugin for scheduling "tryjobs" that they use on chromium/gerrit/go/others https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/refs/heads/main/web/. We could potentially take (inspiration from) some of that code for a clean Gerrit integration.

Pinging maintainers should *possibly* be part of a separate tagging bot tbh, but I can also see wanting to just shove it in buildbot to use buildbot to deal with the gerrit API bits. It looks like Google has a thingy here that has a web plugin for scheduling "tryjobs" that they use on chromium/gerrit/go/others https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/refs/heads/main/web/. We could potentially take (inspiration from) some of that code for a clean Gerrit integration.
k900 commented 2024-09-02 11:01:00 +00:00
Author
Member
Copy link

The reason I want pinging maintainers in ofborg and not in some other place is for it to be consistent with what packages we consider "affected" by a certain PR (i.e. what gets rebuilt etc)

The reason I want pinging maintainers in ofborg and not in some other place is for it to be consistent with what packages we consider "affected" by a certain PR (i.e. what gets rebuilt etc)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
non-flakes
forkos
refactor
authz
jade/deny-flake-config
fallable-binary-cache
gerrit
better-gerrit
puck/gerrit-changes
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/buildbot-nix#20
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?