Operation Buildborg #20
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
aka building ofborg on top of buildbot
Core ofborg features we need in rough order of complexity:
Pinging maintainers should possibly be part of a separate tagging bot tbh, but I can also see wanting to just shove it in buildbot to use buildbot to deal with the gerrit API bits.
It looks like Google has a thingy here that has a web plugin for scheduling "tryjobs" that they use on chromium/gerrit/go/others https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/refs/heads/main/web/. We could potentially take (inspiration from) some of that code for a clean Gerrit integration.
The reason I want pinging maintainers in ofborg and not in some other place is for it to be consistent with what packages we consider "affected" by a certain PR (i.e. what gets rebuilt etc)
I'll probably comment with more ofborg load-bearing quirks, but not listed yet above is eval cleanliness checks, i.e. no trace warnings or anything during normal package-set eval with aliases disabled. In ofborg this happens during each outpath calculation step and during check-meta-queue-builds step, but not during other eval checks (and e.g. the aliases-enabled check definitely needs to not check for trace output)
As long as it happens at all though, I'm indifferent where/how it happens in Buildborg