From d21f406a2534d989c819da1bdab9ce336b0fac71 Mon Sep 17 00:00:00 2001
From: Yureka <yuka@yuka.dev>
Date: Tue, 6 Aug 2024 10:54:44 +0200
Subject: [PATCH] randomly pick a builder and pass it as --store

---
 buildbot_nix/__init__.py | 40 ++++++++++++++++++++++++----------------
 1 file changed, 24 insertions(+), 16 deletions(-)

diff --git a/buildbot_nix/__init__.py b/buildbot_nix/__init__.py
index 83b0eb6..07543f3 100644
--- a/buildbot_nix/__init__.py
+++ b/buildbot_nix/__init__.py
@@ -4,6 +4,7 @@ import os
 import sys
 import graphlib
 import base64
+import random
 from collections.abc import Generator
 from dataclasses import dataclass, field
 from pathlib import Path
@@ -60,13 +61,16 @@ class NixBuilder:
     supportedFeatures: list[str] = field(default_factory=lambda: [])
     mandatoryFeatures: list[str] = field(default_factory=lambda: [])
 
-    def to_nix_line(self):
-        systems = ["-"] if not self.systems else self.systems
-        supportedFeatures = ["-"] if not self.supportedFeatures else self.supportedFeatures
-        mandatoryFeatures = ["-"] if not self.mandatoryFeatures else self.mandatoryFeatures
-        encoded_public_key = base64.b64encode(self.publicHostKey.encode('ascii')).decode('ascii') if self.publicHostKey is not None else "-"
-        fullConnection = f"{self.protocol}://{self.sshUser}@{self.hostName}" if self.sshUser is not None else self.hostName
-        return f"{fullConnection} {",".join(systems)} {self.sshKey or "-"} {self.maxJobs} {self.speedFactor} {",".join(supportedFeatures)} {",".join(mandatoryFeatures)} {encoded_public_key}"
+    def to_nix_store(self):
+        fullConnection = f"{self.sshUser}@{self.hostName}" if self.sshUser is not None else self.hostName
+        fullConnection = f"{self.protocol}://{fullConnection}"
+        if self.sshKey is not None:
+            fullConnection += f"?ssh-key={self.sshKey}"
+        if self.publicHostKey is not None:
+            encoded_public_key = base64.b64encode(self.publicHostKey.encode('ascii')).decode('ascii')
+            fullConnection += f"?base64-ssh-public-host-key={encoded_public_key}"
+
+        return fullConnection
 
 
 @dataclass
@@ -619,7 +623,7 @@ def nix_build_config(
     project: GerritProject,
     worker_arch: str,
     worker_names: list[str],
-    builders_spec: str,
+    build_stores: list[str],
     signing_keyfile: str | None = None,
     binary_cache_config: S3BinaryCacheConfig | None = None
 ) -> util.BuilderConfig:
@@ -639,6 +643,9 @@ def nix_build_config(
         )
     )
 
+    # pick a store to run the build on
+    build_store = random.choice(build_stores)
+
     factory.addStep(
         NixBuildCommand(
             env={},
@@ -656,10 +663,10 @@ def nix_build_config(
                 # stop stuck builds after 20 minutes
                 "--max-silent-time",
                 str(60 * 20),
-                "--builders",
-                builders_spec,
                 "--store",
-                util.Interpolate("%(prop:builddir)s/store"),
+                build_store,
+                "--eval-store",
+                "ssh-ng://localhost",
                 "--out-link",
                 util.Interpolate("result-%(prop:attr)s"),
                 util.Interpolate("%(prop:drv_path)s^*"),
@@ -680,7 +687,7 @@ def nix_build_config(
                     "store",
                     "sign",
                     "--store",
-                    util.Interpolate("%(prop:builddir)s/store"),
+                    build_store,
                     "--key-file",
                     signing_keyfile,
                     util.Interpolate(
@@ -697,6 +704,8 @@ def nix_build_config(
                 command=[
                     "nix",
                     "copy",
+                    "--store",
+                    build_store,
                     "--to",
                     f"s3://{binary_cache_config.bucket}?profile={binary_cache_config.profile}&region={binary_cache_config.region}&endpoint={binary_cache_config.endpoint}",
                     util.Property(
@@ -758,7 +767,7 @@ def config_for_project(
     nix_eval_worker_count: int,
     nix_eval_max_memory_size: int,
     eval_lock: util.MasterLock,
-    builders_spec: str,
+    nix_builders: list[NixBuilder],
     signing_keyfile: str | None = None,
     binary_cache_config: S3BinaryCacheConfig | None = None
 ) -> Project:
@@ -815,7 +824,7 @@ def config_for_project(
                     project,
                     arch,
                     [ f"{w}-{arch}" for w in worker_names ],
-                    builders_spec,
+                    [b.to_nix_store() for b in nix_builders if arch in b.systems or arch == "other"],
                     signing_keyfile=signing_keyfile,
                     binary_cache_config=binary_cache_config
                 )
@@ -954,7 +963,6 @@ class GerritNixConfigurator(ConfiguratorBase):
 
         eval_lock = util.MasterLock("nix-eval")
 
-        builders_spec = " ; ".join(builder.to_nix_line() for builder in self.nix_builders)
         for project in self.projects:
             config_for_project(
                 config,
@@ -965,7 +973,7 @@ class GerritNixConfigurator(ConfiguratorBase):
                 self.nix_eval_worker_count or multiprocessing.cpu_count(),
                 self.nix_eval_max_memory_size,
                 eval_lock,
-                builders_spec,
+                self.nix_builders,
                 signing_keyfile=self.signing_keyfile,
                 binary_cache_config=self.binary_cache_config
             )