lix-community/nix-security-tracker
0
0
Fork 0
Code Issues 94 Pull requests 9 Projects Releases Packages Wiki Activity

Summarise changes in the activity log display #425

New issue
Closed
opened 2024-12-05 18:47:35 +00:00 by erictapen · 6 comments
erictapen commented 2024-12-05 18:47:35 +00:00 (Migrated from github.com)
Copy link

tmp wOxkuJahh3

![tmp wOxkuJahh3](https://github.com/user-attachments/assets/fad9f5b4-b4d1-4795-b83b-8040f8c06b8d)
fricklerhandwerk commented 2024-12-05 20:16:07 +00:00 (Migrated from github.com)
Copy link

Ah, this is because we're not removing them in one transaction since the htmx stuff. How about debouncing and batching the removal, e.g. by only sending a bulk request when

  • the suggestion scrolls out of view
  • when the state changes
  • some timer runs out?
Ah, this is because we're not removing them in one transaction since the htmx stuff. How about debouncing and batching the removal, e.g. by only sending a bulk request when - the suggestion scrolls out of view - when the state changes - some timer runs out?
erictapen commented 2024-12-06 08:49:01 +00:00 (Migrated from github.com)
Copy link

Mh I don't like breaking the promise, that changes are immediate. What if the user closes the browser tab before scrolling further?

Mh I don't like breaking the promise, that changes are immediate. What if the user closes the browser tab before scrolling further?
fricklerhandwerk commented 2024-12-06 10:00:08 +00:00 (Migrated from github.com)
Copy link

Yeah, I was just thinking we'd have to put roughly the same logic for grouping changes into either component. But I guess if we issue a random token with each static page and send it back on change, grouping activities by that token will be a pretty good approximation.

Yeah, I was just thinking we'd have to put roughly the same logic for grouping changes into either component. But I guess if we issue a random token with each static page and send it back on change, grouping activities by that token will be a pretty good approximation.
erictapen commented 2024-12-06 10:09:07 +00:00 (Migrated from github.com)
Copy link

Ah I was just thinking about grouping by time delta tbh. Everything from the same user within 5min distance should be grouped together.

Ah I was just thinking about grouping by time delta tbh. Everything from the same user within 5min distance should be grouped together.
👍 1
alejandrosame commented 2024-12-08 17:40:21 +00:00 (Migrated from github.com)
Copy link

If we are to group by time delta, how should the ISO timestamps be displayed?

For example, should it be displayed as the first and last timestamp like 2024-11-26T11:38:41+00:00 to 2024-11-26T11:43:41+00:00?

If we are to group by time delta, how should the ISO timestamps be displayed? For example, should it be displayed as the first and last timestamp like `2024-11-26T11:38:41+00:00 to 2024-11-26T11:43:41+00:00`?
fricklerhandwerk commented 2024-12-08 18:11:24 +00:00 (Migrated from github.com)
Copy link

I'd keep it simple and only display the last one.

I'd keep it simple and only display the last one.
👍 2
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
npins-auto-update
No results found.
Labels
Clear labels   
automation

   
backend

something the web server needs to provide the frontend with

  
bug

Something isn't working

  
contributor experience

   
data

something about quality or quantity of ingested data

  
deployment

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
nice to have

Nice to have, but not necessary for the time being

  
notifications

   
package maintainer

user story for package maintainers

  
performance

   
skin

Anything related to the visual presentation

  
tech debt

Activities that reduce tech debt

  
user story

description or implementation of a workflow

No labels
automation
backend
bug
contributor experience
data
deployment
documentation
duplicate
good first issue
help wanted
nice to have
notifications
package maintainer
performance
skin
tech debt
user story
Milestone
Clear milestone
No items
No milestone
3 Security team demo
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-community/nix-security-tracker#425
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?